Fix libdnf5::utils::patterns: Include missing headers, no inline API funcs, mark noexcept

include/libdnf5/utils/patterns.hpp

@@ -20,25 +20,23 @@ along with libdnf. If not, see <https://www.gnu.org/licenses/>.
 #ifndef LIBDNF5_UTILS_PATTERNS_HPP
 #define LIBDNF5_UTILS_PATTERNS_HPP
 
+#include "libdnf5/defs.h"
+
+#include <string>
+
 namespace libdnf5::utils {
 
 /// @brief Check if a given pattern is a GLOB.
 ///
 /// @param pattern Text pattern to be test
 /// @return True if a given pattern is a GLOB
-inline bool is_glob_pattern(const char * pattern) {
- return strpbrk(pattern, "*[?") != nullptr;
-}
-
-/// Return true if given pattern is a file path
+LIBDNF_API bool is_glob_pattern(const char * pattern) noexcept;
 
 /// @brief Check if a given pattern is a file path.
 ///
 /// @param pattern Text pattern to be test
 /// @return True if a given pattern is a file path
-inline bool is_file_pattern(const std::string & pattern) {
- return pattern[0] == '/' || (pattern[0] == '*' && pattern[1] == '/');
-}
+LIBDNF_API bool is_file_pattern(const std::string & pattern) noexcept;
 
 } // namespace libdnf5::utils
 

libdnf5/utils/patterns.cpp

@@ -0,0 +1,34 @@
+/*
+Copyright Contributors to the libdnf project.
+
+This file is part of libdnf: https://github.com/rpm-software-management/libdnf/
+
+Libdnf is free software: you can redistribute it and/or modify
+it under the terms of the GNU Lesser General Public License as published by
+the Free Software Foundation, either version 2.1 of the License, or
+(at your option) any later version.
+
+Libdnf is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+GNU Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public License
+along with libdnf. If not, see <https://www.gnu.org/licenses/>.
+*/
+
+#include "libdnf5/utils/patterns.hpp"
+
+#include <cstring>
+
+namespace libdnf5::utils {
+
+bool is_glob_pattern(const char * pattern) noexcept {
+ return strpbrk(pattern, "*[?") != nullptr;
+}
+
+bool is_file_pattern(const std::string & pattern) noexcept {
+ return pattern[0] == '/' || (pattern[0] == '*' && pattern[1] == '/');
+}
+
+} // namespace libdnf5::utils