Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic: Use original dnf4 config file location #1690

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Sep 11, 2024

Since the automatic configuration file remains compatible, this change
makes the upgrade dnf4->dnf5 easier for the user.
Having so many automatic config files seems overly complicated so the
change also deprecates /etc/dnf/dnf5-plugins/automatic.conf location and
warns the user if they use it.

Resolves: #1624

@ppisar ppisar self-assigned this Sep 11, 2024
Since the automatic configuration file remains compatible, this change
makes the upgrade dnf4->dnf5 easier for the user.
Having so many automatic config files seems overly complicated so the
change also deprecates /etc/dnf/dnf5-plugins/automatic.conf location and
warns the user if they are using it.
Copy link
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. It works for me. The build failures in CI are caused by toml11 which not relevant here.

@ppisar ppisar added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 73ed42f Sep 11, 2024
12 of 20 checks passed
@ppisar ppisar deleted the mblaha/automatic-config branch September 11, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatic: Consider reading the dnf4 configuration file for backward compatibility
2 participants