Use correct path when destdir option is set #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the path where a package should be downloaded is computed in several places. This patch introduces a single location for this computation to reduce code duplication. The patch also fixes usage of incorrect package path in Package::get_package_path() call - the destdir config option was not taken into account.
|
Thanks for the patch! I noticed one test that looks related to the change broke ("skip downloading of already downloaded rpm file" in the dnf/download.feature). |
|
Yeah, I was lazy to run the tests locally and that's the result... I'll check it out, meanwhile switching to draft state. |
|
So the issue is not with this PR itself, but was introduced in commit 59538f3 which did not properly call download callbacks in case the source and destination of a downloaded file were the same. The problem did not surface before this PR, because the package was not correctly identified as locally available due to an incorrect path being used. |
The download callbacks were not called in case the source and destination of locally available downloaded file were the same.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
1e83b07 (Marek Blaha, 9 minutes ago)
repo: New Repo.get_packages_download_dir() method
Currently, the path where a package should be downloaded is computed in
several places. This patch introduces a single location for this
computation to reduce code duplication. The patch also fixes usage of
incorrect package path in Package::get_package_path() call - the destdir
config option was not taken into account.
07105d0 (Marek Blaha, 2 hours ago)
doc: Document destdir main config option
Resolves: #1620
Tests: rpm-software-management/ci-dnf-stack#1536