Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements and fixes for storing transactions #1585

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Improvements and fixes for storing transactions #1585

merged 5 commits into from
Jul 17, 2024

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Jul 16, 2024

@kontura
Store to the db only requested package types for group
e465b13 
Previously it stored all package types present in the group but we want
only the ones the user requested.
This matches dnf4 behavior.
@kontura
Rename wrongly names query_format name to output_arg
ac93ee2
@kontura
Improve history store message to mention transaction ID
df7970f
@kontura
history store add user friendly message when operation succeeds
25655e3
@kontura
Use the same nevra format for history and regular transactions
f5c356e 
When serializing a history transaction package nevra use the same format
that is used when serializing base transaction.

It is also described in a comment: https://github.com/rpm-software-management/dnf5/blob/main/libdnf5/transaction/transaction_sr.hpp#L62
@kontura kontura marked this pull request as ready for review July 16, 2024 12:35
@kontura kontura mentioned this pull request Jul 16, 2024
Merged
@pkratoch pkratoch self-assigned this Jul 16, 2024
@kontura
Copy link
Contributor Author

kontura commented Jul 17, 2024

Just to clarify the Store to the db only requested package types for group commit, when a history transaction is stored (history store command) is takes the used package_types from the db. The problem was that the db always contained all types present in the selected group, now it contains only the selected types.

For example if someone preformed a group install with just mandatory packages and then history stored the transaction in the json it would wrongly say the transaction contained all present types (not just mandatory).

@pkratoch pkratoch added this pull request to the merge queue Jul 17, 2024
Merged via the queue into rpm-software-management:main with commit 5c76f5e Jul 17, 2024
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pkratoch pkratoch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kontura @pkratoch