Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Review of DNF4 vs DNF5 CLI and configuration changes #1414

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

jan-kolarik
Copy link
Member

@jan-kolarik jan-kolarik commented Apr 15, 2024

Related to #1290.
Closes #940.

@jan-kolarik jan-kolarik force-pushed the jkolarik/dnf4-dnf5-cli-changes-review branch from bf8916d to dce2d92 Compare April 15, 2024 10:19
Comment on lines +159 to +160
``builddep``
* Dropped ``--spec`` and ``--srpm`` arguments as automatic detection from file extensions is implemented now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably a bad idea because there is no guarantee we can detect from file extensions. I've seen spec files with all kinds of crazy file names, and while it's not super-common anymore to see .spm or similar weird things for SRPMs, it's still possible since RPM allows reconfiguring the package filename template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, interesting, I wouldn't think of that. This implementation of the builddep plugin is there from the beginning and I don't see any explicit request to do it in the automatic way, so we can definitely think about bringing back the original behavior. Could you create an issue for that please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There already is #799 and the associated PR #810

Comment on lines +213 to +214
``makecache``
* Metadata is now stored in different directories, see the ``cachedir`` configuration option :ref:`changes <cachedir_option_conf_changes_ref-label>` for more details.
Copy link
Member

@Conan-Kudo Conan-Kudo Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command needs to exist for when users disable on-demand cache downloading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The makecache command still exists I think this is just explanation that dnf5 stores cache at different location.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, in this section there is always a list of changes related to an individual command. If the command is entirely dropped, it's explicitly stated here. I hope it will be better visible in the final HTML format of the docs, though there was already some confusion mentioned on the proposal discussion related to this "changes doc", so if you have a specific tip how to improve the situation, please share it with us 🙂

@kontura kontura self-assigned this Apr 16, 2024
doc/changes.rst Outdated Show resolved Hide resolved
@jan-kolarik jan-kolarik force-pushed the jkolarik/dnf4-dnf5-cli-changes-review branch from dce2d92 to cfe2cc4 Compare April 16, 2024 12:51
@kontura kontura added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 71e70fa Apr 18, 2024
14 of 18 checks passed
@kontura kontura deleted the jkolarik/dnf4-dnf5-cli-changes-review branch April 18, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

doc: dnf5 mark documentation issues
3 participants