-
Notifications
You must be signed in to change notification settings - Fork 410
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
comps: Make the install_or_skip() method not catch CompsError anymore
According to its docstring, the original intention of the method was to not fail on installing an already installed group/environment. However, the CompsError is no longer thrown when attempting to install an already installed group or environment. It was changed to logging a warning directly in 5210b9d and then the check was removed completely in 217ca0f. For the other case for which an instance of CompsError can be thrown from the install_group() and install_environment() methods, which is when a group or environment is not found, we certainly want to throw an error (see the linked bugs), therefore there's no reason to catch the exception anymore. The install_or_skip() method is preserved as part of the API so as not to break compatibility any more than necessary. msg: API: Raise CompsError when group/env not found in install_group and install_environment type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1947958 related: https://bugzilla.redhat.com/show_bug.cgi?id=1943206
- Loading branch information
Showing
4 changed files
with
16 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters