Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect CentOS properly instead of defaulting to epel #525

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Detect CentOS properly instead of defaulting to epel #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2aaeccb
Detect CentOS properly instead of defaulting to epel
jakub-vavra-cz Mar 1, 2024
3439358
Add myself as contributor in AUTHORS
jakub-vavra-cz Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ DNF-PLUGINS-CORE CONTRIBUTORS
David Michael <[email protected]>
François Rigault <[email protected]>
Hedayat Vatankhah <[email protected]>
Jakub Vavra <[email protected]>
Jeff Smith <[email protected]>
Lubomir Rintel <[email protected]>
Luigi Toscano <[email protected]>
Expand Down
2 changes: 2 additions & 0 deletions plugins/copr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,8 @@ def _guess_chroot(self):
chroot = ("fedora-rawhide-" + distarch)
else:
chroot = ("fedora-{0}-{1}".format(dist[1], distarch))
elif "CentOS Stream" in dist:
chroot = ("centos-stream-{}-{}".format(dist[1].split(".", 1)[0], distarch if distarch else "x86_64"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update.

This is not something I'd love to make decisions on. I'd suggest you: ask the CentOS Stream community.

Just note that the CentOS Stream build chroots have a lower chance to even exist in the project:
image

And then, from my observation only, it is a relatively known fact that epel-* is the default decision DNF copr plugin on the Enterprise Linux-based distros, so if anyone has to provide some "stable and supported content" in Copr for EL, they provide epel- chroots. The centos-stream-* or centos-stream+epel-* chroots in Fedora Copr are typically used just for CI testing.

elif "Mageia" in dist:
# Get distribution architecture (Mageia does not use $basearch)
distarch = rpm.expandMacro("%{distro_arch}")
Expand Down
Loading