module/updateinfo: Disable failing test #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After merging rpm-software-management#1540, it was revealed that this test in module/updateinfo.feature wasn't actually testing anything, and the behavior it intends to test is (and has long been?) broken. The test was expecting an empty stdout (or <REPOSYNC>), which it was getting, but only after refactoring the tests did we notice the message on stderr: Unknown argument "--list" for command "updateinfo". For now, I've updated the test to call the correct command, `updateinfo list`, and disabled the test since it is now failing (but in a more valid way).
|
Let's disable it for now and discuss it in the follow-up issue: #1548. |
jan-kolarik
merged commit dab0e39
into
rpm-software-management:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #1540, it was revealed that this test in
module/updateinfo.featurewasn't actually testing anything, and the behavior it intends to test is (and has long been?) broken. The test was expecting an empty stdout (or<REPOSYNC>), which it was getting, but only after refactoring the tests did we notice the message on stderr:For now, I've updated the test to call the correct command,
updateinfo list, and disabled the test since it is now failing (but in a more valid way):Another option would be to fix the test to use the correct command, but leave it enabled and failing.
cc @pkratoch, do you have an idea of what the problem is and how long it might take to fix? If it's complicated/low priority, we can go ahead and disable the test and put an issue on the backlog for it, otherwise maybe it's better to go ahead and fix it instead of disabling then immediately re-enabling it.