Replace FileOptions::is_noreplace() with ::is_config_noreplace()

CHANGELOG.md

@@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - `Dependency::rpmlib()` now inserts the `rpmlib()` portion automatically, only the feature name itself should
  be provided in the string passed as the name argument.
+- `FileOptions::is_no_replace()` is now `FileOptions::is_config_noreplace()` to reflect the fact that the noreplace
+ flag is only applicable to config files, and have more similar usage relative to `%config(noreplace)`
 
 ### Added
 

src/rpm/headers/types.rs

@@ -297,16 +297,18 @@ impl FileOptionsBuilder {
  self
  }
 
- /// Indicates that a (configuration) file should not be replaced if it has been modified.
- /// When a package is updated, configuration files will be checked for modifications compared
- /// to their default state, and if any are present then the new configuration file will
+ /// Indicates that a file is a configuration file and that it should not be replaced if it has been
+ /// modified. When a package is updated, configuration files will be checked for modifications
+ /// compared to their default state, and if any are present then the new configuration file will
  /// be installed with a .rpmnew extension.
  ///
  /// User intervention may be required to reconcile the changes between the new and old configs.
  ///
  /// See: %config(noreplace) from specfile syntax
- pub fn is_no_replace(mut self) -> Self {
- self.inner.flag.insert(FileFlags::NOREPLACE);
+ pub fn is_config_noreplace(mut self) -> Self {
+ self.inner
+ .flag
+ .insert(FileFlags::CONFIG | FileFlags::NOREPLACE);
  self
  }
 

src/tests.rs

@@ -30,9 +30,7 @@ However, it does nothing.",
  .compression(rpm::CompressionType::Gzip)
  .with_file(
  "Cargo.toml",
- FileOptions::new("/etc/awesome/config.toml")
- .is_config()
- .is_no_replace(),
+ FileOptions::new("/etc/awesome/config.toml").is_config_noreplace(),
  )?
  // file mode is inherited from source file
  .with_file("Cargo.toml", FileOptions::new("/usr/bin/awesome"))?

tests/compat.rs

@@ -51,8 +51,7 @@ mod pgp {
  cargo_file.to_str().unwrap(),
  FileOptions::new("/etc/foobar/hugo/bazz.toml")
  .mode(0o100_777)
- .is_config()
- .is_no_replace(),
+ .is_config_noreplace(),
  )?
  .with_file(
  cargo_file.to_str().unwrap(),