Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts][safe-room] Add support for new empath spell healing plant #6658

Merged
merged 3 commits into from
Jul 29, 2023

Conversation

MahtraDR
Copy link
Collaborator

Adding support for the new empath spell Embrace of the Vela'Tohr creates a plant that one can touch to get healed (the plant is like a wound bank) the empath can then come around later and heal the plant.

This PR adds the plant as a healing option to safe-room. By default, I've made the plant take priority over NPC empaths, and player empaths take priority over the plant.

I haven't decided if I want it opt-in, or opt-out, or not optional?

@gmfaux
Copy link

gmfaux commented Jul 28, 2023

If the plant is almost at capacity, and you are very wounded and touch it, I believe there is a chance that in taking your wounds it will reach its capacity and 'shut down', but you will still have wounds left over. In that case, you would have to either touch again if a plant/thicket is present, or proceed to other sources of healing?

@MahtraDR
Copy link
Collaborator Author

If the plant is almost at capacity, and you are very wounded and touch it, I believe there is a chance that in taking your wounds it will reach its capacity and 'shut down', but you will still have wounds left over. In that case, you would have to either touch again if a plant/thicket is present, or proceed to other sources of healing?

As is, this change doesn't assume the plant is be all end all, it just tries to touch, in addition to whatever other source of healing it would normally do. In the scenario you describe, it would then proceed to wait for the autopath/empath to finish healing then.

@MahtraDR MahtraDR merged commit 529b145 into rpherbig:master Jul 29, 2023
2 checks passed
@gmfaux
Copy link

gmfaux commented Jul 29, 2023

@MahtraDR what if the room only has a plant and it dies?

@MahtraDR
Copy link
Collaborator Author

@MahtraDR what if the room only has a plant and it dies?

In that scenario you won't get healed, and the logic flow continues as if there'd never been a plant, or empath in there.

@gmfaux
Copy link

gmfaux commented Jul 29, 2023

Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants