Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use the overhauled GPIO API #1

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Update to use the overhauled GPIO API #1

merged 5 commits into from
Nov 10, 2023

Conversation

ithinuel
Copy link
Member

Depends on rp-rs/rp-hal#585

@ithinuel ithinuel force-pushed the experiment-gpio-overhaul branch 4 times, most recently from 0541f35 to 55faaba Compare October 14, 2023 20:12
9names
9names approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
My comments are nitpicks and overarching design questions that, if any change is required, should be resolved in other issues/PRs.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@ithinuel ithinuel merged commit 71cfea1 into rp-rs:main Nov 10, 2023
4 checks passed
@ithinuel ithinuel deleted the experiment-gpio-overhaul branch November 10, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9names 9names 9names approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithinuel @9names