NeoMutt 2018-02-23

royger · Feb 23, 2018 · 5a3bda2 · 5a3bda2
2 parents a45635c + 45d051e
commit 5a3bda2
Show file tree

Hide file tree

Showing 100 changed files with 19,349 additions and 19,301 deletions.
diff --git a/.mailmap b/.mailmap
@@ -1,5 +1,6 @@
 ## NeoMutt Contributors
 Adam Borowski <[email protected]>                             Adam Borowski <[email protected]>                      # @kilobyte
+Aleksa Sarai <[email protected]>                                Aleksa Sarai <[email protected]>                         # @cyphar
 Andreas Rammhold <[email protected]>                          Andreas Rammhold <[email protected]>                   # @andir
 André Berger <[email protected]>                                André Berger <[email protected]>                         # @hvkls
 André Berger <[email protected]>                              André Berger <[email protected]>                       # @hvkls
@@ -8,6 +9,7 @@ Anton Rieger <[email protected]>                        seishinryohosha
 Antonio Radici <[email protected]>                               Antonio Radici <[email protected]>                        # @aradici
 Antonio Radici <[email protected]>                               Unknown <[email protected]>                               # @aradici
 Austin Ray <[email protected]>                          Austin Ray <[email protected]>                   # @austin-ray
+Benjamin Mako Hill <[email protected]>                              Benjamin Mako Hill <[email protected]>                       # @makoshark
 Bernard Pratz <[email protected]>                       Bernard 'Guyzmo' Pratz <[email protected]>       # @guyzmo
 Bernard Pratz <[email protected]>                       Bernard Pratz <[email protected]>                # @guyzmo
 Bernard Pratz <[email protected]>                       Guyzmo <[email protected]>                       # @guyzmo
@@ -51,15 +53,19 @@ Jonathan Perkin <[email protected]>                            Jonathan Perkin
 Joshua Jordi <[email protected]>                             Jakkin <[email protected]>                            # @jakkinstewart
 Joshua Jordi <[email protected]>                             Joshua Jordi <[email protected]>    # @jakkinstewart
 Julian Andres Klode <[email protected]>                         Julian Andres Klode <[email protected]>                  # @julian-klode
+Justin Vasel <[email protected]>                           Justin Vasel <[email protected]>                    # @justinvasel
 Karel Zak <[email protected]>                                     Karel Zak <[email protected]>                              # @karelzak
 Kevin Decherf <[email protected]>                              Kevin Decherf <[email protected]>                       # @kdecherf
 Kevin Velghe <[email protected]>                                 Kevin Velghe <[email protected]>                          # @paretje
 Larry Rosenman <[email protected]>                             Larry Rosenman <[email protected]>                      # @lrosenman
+Leo Lundgren <[email protected]>                              Leo R. Lundgren <[email protected]>                    # @rawtaz
 Manos Pitsidianakis <[email protected]>                      Manos Pitsidianakis <[email protected]>               # @epilys
 Marcin Rajner <[email protected]>                           Marcin Rajner lenovo <[email protected]>             # @mrajner
 Marco Hinz <[email protected]>                               Marco Hinz <[email protected]>                        # @mhinz
+Marius Gedminas <[email protected]>                              Marius Gedminas <[email protected]>                       # @mgedmin
 Mehdi Abaakouk <[email protected]>                              Mehdi ABAAKOUK <[email protected]>                       # @sileht
 Mehdi Abaakouk <[email protected]>                              Mehdi Abaakouk <[email protected]>                       # @sileht
+Michael Bazzinotti <[email protected]>                      Michael J. Bazzinotti <[email protected]>            # @bazzinotti
 ng0 <[email protected]>                                      ng0 <[email protected]>                               # @ng-0
 Nicolas Bock <[email protected]>                            Nicolas Bock <[email protected]>                     # @nicolasbock
 Peter Hogg <[email protected]>                                  Pig Monkey <[email protected]>                           # @pigmonkey
@@ -84,6 +90,7 @@ Stefan Assmann <[email protected]>                             Stefan Assmann <
 Stefan Bühler <[email protected]>                                Stefan Bühler <[email protected]>                         # @stbuehler
 Stephen Gilles <[email protected]>                           S. Gilles <[email protected]>                         #
 Steven Ragnarök <[email protected]>                    Steven! Ragnarök <[email protected]>            # @nuclearsandwich
+Theo Jepsen <[email protected]>                              Theo <theojepsen@g-m-a-i-l-dotcom>                       # @theojepsen
 Thomas Adam <[email protected]>                                 Thomas Adam <[email protected]>                          # @thomasadam
 Thomas Klausner <[email protected]>                                Thomas Klausner <[email protected]>                         # @0-wiz-0
 Tobias Angele <[email protected]>                             Tobias Angele <[email protected]>                      # @toogley
@@ -178,6 +185,7 @@ Gary Johnson <[email protected]>                         Gary Johnson <ga
 Gary Johnson <[email protected]>                         Gary Johnson <unknown>
 Gero Treuner <[email protected]>                 Gero Treuner <[email protected]>
 Gregory Shapiro <[email protected]>                   Gregory Shapiro <[email protected]>
+Grzegorz Szymaszek <[email protected]>                        Grzegorz Szymaszek <[email protected]>
 Guilhem Moulin <[email protected]>                            Guilhem Moulin <[email protected]>
 guns <[email protected]>                                         guns <[email protected]>
 H.N.Caldwell <unknown>                                          hncaldwell <unknown>
@@ -217,6 +225,7 @@ Kevin McCarthy <[email protected]>                                   Kevin McCarthy <
 Kevin Scannell <[email protected]>                              Kevin Scannell <[email protected]>
 Kevin Scannell <[email protected]>                              Kevin Scannell <[email protected]>
 Kimihiro Nonaka <[email protected]>                             NONAKA Kimihiro <[email protected]>
+Konstantin Stephan <[email protected]>                          Konstantin Stephan <[email protected]>
 Kyle Wheeler <[email protected]>                              Kyle Wheeler <[email protected]>
 Kyle Wheeler <[email protected]>                              Kyle Wheeler <[email protected]>
 Kyle Wheeler <[email protected]>                              Kyle Wheeler <unknown>

diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,3 +1,61 @@
+2018-02-23  Richard Russon  <[email protected]>
+* Features
+  - browser: `<goto-parent>` function bound to "p"
+  - editor: `<history-search>` function bound to "Ctrl-r"
+  - Cygwin support: https://www.neomutt.org/distro/cygwin
+  - OpenSUSE support: https://www.neomutt.org/distro/suse
+  - Upstream Homebrew support: Very soon - https://www.neomutt.org/distro/homebrew
+* Bug Fixes
+  - gmail server-size search
+  - nested-if: correctly handle "<" and ">" with %?
+  - display of special chars
+  - lua: enable myvars
+  - for pgpewrap in default gpg.rc
+  - reply_regexp which wasn't formatted correctly.
+  - parsing of urls containing '?'
+  - out-of-bounds read in mutt_str_lws_len
+* Translations
+  - Review fuzzy lt translations
+  - Updated French translation
+* Website
+  - Installation guide for Cygwin
+  - Installation guide for OpenSUSE
+  - Installation guide for CRUX
+* Build
+  - check that DTDs are installed
+  - autosetup improvements
+  - option for which version of bdb to use
+  - drop test for resizeterm -- it's always present
+* Code
+  - split if's containing assignments
+  - doxygen: add/improve comments
+  - rename functions / parameters for consistency
+  - add missing {}s for clarity
+  - move functions to library
+  - reduce scope of variables
+  - boolify more variables
+  - iwyu: remove unnecessary headers
+  - name unicode chars
+  - tailq: migrate parameter api
+  - md5: refactor and tidy
+  - rfc2047: refactor and tidy
+  - buffer: improvements
+  - create unit test framework
+  - fix several coverity defects
+* Upstream
+  - Fix s/mime certificate deletion bug
+  - Disable message security if the backend is not available
+  - Fix improper signed int conversion of IMAP uid and msn values
+  - Change imap literal counts to parse and store unsigned ints
+  - Fix imap status count range check
+  - cmd_handle_fatal: make error message a bit more descriptive
+  - Create pgp and s/mime default and sign_as key vars
+  - Add missing setup calls when resuming encrypted drafts
+  - mutt_pretty_size: show real number for small files
+  - examine_directory: set directory/symlink size to zero
+  - Add history-search function, bound to ctrl-r
+  - Avoid a potential integer overflow if a Content-Length value is huge
+
 2017-12-15  Richard Russon  <[email protected]>
 * Bug Fixes
   - Fix some regressions in the previous release

diff --git a/README.md b/README.md
@@ -76,27 +76,29 @@ sorted through them, fixed them up and documented them.
 
 Here's a list of everyone who's helped NeoMutt:
 
-Adam Borowski, Alad Wenter, Alex Pearce, Alok Singh, Ander Punnar,
+Adam Borowski, Alad Wenter, Aleksa Sarai, Alex Pearce, Alok Singh, Ander Punnar,
 Andreas Rammhold, André Berger, Anton Rieger, Antonio Radici, Austin Ray,
-Baptiste Daroussin, Bernard Pratz, Bletchley Park, Bo Yu, Bryan Bennett,
-Chris Czettel, Chris Salzberg, Christian Dröge, Christoph Berg, cinder88,
-Clemens Lang, Damien Riegel, Darshit Shah, David Sterba,
+Baptiste Daroussin, Benjamin Mako Hill, Bernard Pratz, Bletchley Park, Bo Yu,
+Bryan Bennett, Chris Czettel, Chris Salzberg, Christian Dröge, Christoph Berg,
+cinder88, Clemens Lang, Damien Riegel, Darshit Shah, David Sterba,
 Dimitrios Semitsoglou-Tsiapos, Doug Stone-Weaver, Edward Betts,
 Elimar Riesebieter, Evgeni Golov, Fabian Groffen, Fabio Alessandro Locati,
-Fabrice Bellet, Faidon Liambotis, Florian Klink, Floyd Anderson,
-František Hájik, Guillaume Brogi, Hugo Barrera, Ian Zimmerman, Ismaël Bouya,
-Ivan Tham, Jack Stratton, Jakub Wilk, Jasper Adriaanse, Jelle van der Waa,
-Jenya Sovetkin, Johannes Frankenau, Johannes Weißl, Jonathan Perkin,
-Joshua Jordi, Julian Andres Klode, Karel Zak, Kevin Decherf, Kevin Velghe,
-Kurt Jaeger, Leonardo Schenkel, Leonidas Spyropoulos, Manos Pitsidianakis,
-Marcin Rajner, Marco Hinz, Matteo Vescovi, Mehdi Abaakouk, ng0, Nicolas Bock,
-Olaf Lessenich, Peter Hogg, Peter Lewis, Phil Pennock, Philipp Marek,
-Pierre-Elliott Bécue, Pietro Cerutti, r3lgar, Regid Ichira, Reis Radomil,
-Riad Wahby, Richard Hartmann, Richard Russon, Rubén Llorente, Santiago Torres,
-Serge Gebhardt, somini, Stefan Assmann, Stefan Bühler, Stephen Gilles,
-Steven Ragnarök, Sven Guckes, Thomas Adam, Thomas Klausner, Thomas Schneider,
-Tobias Angele, Udo Schweigert, Vsevolod Volkov, Werner Fink, Wieland Hoffmann,
-William Pettersson, Yoshiki Vázquez Baeza, Zero King.
+Fabrice Bellet, Faidon Liambotis, Federico Kircheis, Florian Klink,
+Floyd Anderson, František Hájik, Guillaume Brogi, Hugo Barrera, Ian Zimmerman,
+Ismaël Bouya, Ivan Tham, Jack Stratton, Jakub Jindra, Jakub Wilk,
+Jasper Adriaanse, Jelle van der Waa, Jenya Sovetkin, Johannes Frankenau,
+Johannes Weißl, Jonathan Perkin, Joshua Jordi, Julian Andres Klode, Karel Zak,
+Kevin Decherf, Kevin Velghe, Kurt Jaeger, Leo Lundgren, Leonardo Schenkel,
+Leonidas Spyropoulos, Manos Pitsidianakis, Marcin Rajner, Marco Hinz,
+Marius Gedminas, Matteo Vescovi, Mehdi Abaakouk, Michael Bazzinotti, ng0,
+Nicolas Bock, Olaf Lessenich, Peter Hogg, Peter Lewis, Phil Pennock,
+Philipp Marek, Pierre-Elliott Bécue, Pietro Cerutti, r3lgar, Regid Ichira,
+Reis Radomil, Riad Wahby, Richard Hartmann, Richard Russon, Rubén Llorente,
+Santiago Torres, Serge Gebhardt, sharktamer, Shi Lee, somini, Stefan Assmann,
+Stefan Bühler, Stephen Gilles, Steven Ragnarök, Sven Guckes, Theo Jepsen,
+Thomas Adam, Thomas Klausner, Thomas Schneider, Tobias Angele, Udo Schweigert,
+Vsevolod Volkov, Werner Fink, Wieland Hoffmann, William Pettersson,
+Yoshiki Vázquez Baeza, Zero King.
 
 ## Original Patch Authors
 

diff --git a/attach.c b/attach.c
@@ -323,18 +323,18 @@ void mutt_check_lookup_list(struct Body *b, char *type, size_t len)
       if (n != TYPEOTHER)
       {
         snprintf(type, len, "%s/%s",
-                 n == TYPEAUDIO ?
-                     "audio" :
-                     n == TYPEAPPLICATION ?
-                     "application" :
-                     n == TYPEIMAGE ?
-                     "image" :
-                     n == TYPEMESSAGE ?
-                     "message" :
-                     n == TYPEMODEL ? "model" :
-                                      n == TYPEMULTIPART ?
-                                      "multipart" :
-                                      n == TYPETEXT ? "text" : n == TYPEVIDEO ? "video" : "other",
+                 n == TYPEAUDIO ? "audio" :
+                                  n == TYPEAPPLICATION ?
+                                  "application" :
+                                  n == TYPEIMAGE ?
+                                  "image" :
+                                  n == TYPEMESSAGE ?
+                                  "message" :
+                                  n == TYPEMODEL ?
+                                  "model" :
+                                  n == TYPEMULTIPART ?
+                                  "multipart" :
+                                  n == TYPETEXT ? "text" : n == TYPEVIDEO ? "video" : "other",
                  tmp.subtype);
         mutt_debug(1, "\"%s\" -> %s\n", b->filename, type);
       }

diff --git a/auto.def b/auto.def
@@ -14,7 +14,7 @@ use system cc cc-lib mutt-gettext mutt-iconv
 ###############################################################################
 # Names and versions
 define PACKAGE          "neomutt"
-define PACKAGE_VERSION  "20171215"
+define PACKAGE_VERSION  "20180223"
 define BUGS_ADDRESS     "[email protected]"
 
 # Subdirectories that contain additional Makefile.autosetup files

diff --git a/body.c b/body.c
@@ -104,10 +104,10 @@ int mutt_copy_body(FILE *fp, struct Body **tgt, struct Body *src)
   struct Parameter *np, *new;
   TAILQ_FOREACH(np, &src->parameter, entries)
   {
-      new = mutt_param_new();
-      new->attribute = mutt_str_strdup(np->attribute);
-      new->value = mutt_str_strdup(np->value);
-      TAILQ_INSERT_HEAD(&b->parameter, new, entries);
+    new = mutt_param_new();
+    new->attribute = mutt_str_strdup(np->attribute);
+    new->value = mutt_str_strdup(np->value);
+    TAILQ_INSERT_HEAD(&b->parameter, new, entries);
   }
 
   mutt_stamp_attachment(b);

diff --git a/browser.c b/browser.c
@@ -337,8 +337,7 @@ static const char *folder_format_str(char *buf, size_t buflen, size_t col, int c
         else
         {
           tnow = time(NULL);
-          t_fmt =
-              tnow - folder->ff->mtime < 31536000 ? "%b %d %H:%M" : "%b %d  %Y";
+          t_fmt = tnow - folder->ff->mtime < 31536000 ? "%b %d %H:%M" : "%b %d  %Y";
         }
 
         if (!do_locales)
@@ -730,7 +729,8 @@ static int examine_directory(struct Menu *menu, struct BrowserState *state,
         continue;
       if (prefix && *prefix && (strncmp(prefix, nntp_data->group, strlen(prefix)) != 0))
         continue;
-      if (Mask && Mask->regex && !((regexec(Mask->regex, nntp_data->group, 0, NULL, 0) == 0) ^ Mask->not))
+      if (Mask && Mask->regex &&
+          !((regexec(Mask->regex, nntp_data->group, 0, NULL, 0) == 0) ^ Mask->not))
         continue;
       add_folder(menu, state, nntp_data->group, NULL, NULL, NULL, nntp_data);
     }
@@ -788,7 +788,8 @@ static int examine_directory(struct Menu *menu, struct BrowserState *state,
       {
         continue;
       }
-      if (Mask && Mask->regex && !((regexec(Mask->regex, de->d_name, 0, NULL, 0) == 0) ^ Mask->not))
+      if (Mask && Mask->regex &&
+          !((regexec(Mask->regex, de->d_name, 0, NULL, 0) == 0) ^ Mask->not))
         continue;
 
       mutt_file_concat_path(buffer, d, de->d_name, sizeof(buffer));
@@ -1411,7 +1412,7 @@ void mutt_select_file(char *f, size_t flen, int flags, char ***files, int *numfi
 #ifdef USE_IMAP
             || state.entry[menu->current].inferiors
 #endif
-            )
+        )
         {
           /* make sure this isn't a MH or maildir mailbox */
           if (buffy)
@@ -1433,7 +1434,7 @@ void mutt_select_file(char *f, size_t flen, int flags, char ***files, int *numfi
 #ifdef USE_IMAP
               || state.entry[menu->current].inferiors
 #endif
-              )
+          )
           {
             /* save the old directory */
             mutt_str_strfcpy(OldLastDir, LastDir, sizeof(OldLastDir));
@@ -1548,7 +1549,7 @@ void mutt_select_file(char *f, size_t flen, int flags, char ***files, int *numfi
 #endif
         else
           mutt_file_concat_path(f, LastDir, state.entry[menu->current].name, flen);
-      /* fallthrough */
+        /* fallthrough */
 
       case OP_EXIT:
 

diff --git a/buffy.c b/buffy.c
@@ -91,8 +91,7 @@ static int fseek_last_message(FILE *f)
     /* 'i' is Index into `buffer' for scanning.  */
     for (int i = bytes_read; i >= 0; i--)
     {
-      if (mutt_str_strncmp(buffer + i, "\n\nFrom ",
-                           mutt_str_strlen("\n\nFrom ")) == 0)
+      if (mutt_str_strncmp(buffer + i, "\n\nFrom ", mutt_str_strlen("\n\nFrom ")) == 0)
       { /* found it - go to the beginning of the From */
         fseeko(f, pos + i + 2, SEEK_SET);
         return 0;

diff --git a/color.c b/color.c
@@ -537,7 +537,7 @@ static int parse_uncolor(struct Buffer *buf, struct Buffer *s, unsigned long dat
       /* We don't even have colors compiled in */
       parse_uncolor
 #endif
-          )
+  )
   {
     /* just eat the command, but don't do anything real about it */
     do
@@ -871,7 +871,8 @@ static int parse_color(struct Buffer *buf, struct Buffer *s, struct Buffer *err,
 
 #ifdef HAVE_COLOR
 #ifdef HAVE_USE_DEFAULT_COLORS
-  if (!OPT_NO_CURSES && has_colors()
+  if (!OPT_NO_CURSES &&
+      has_colors()
       /* delay use_default_colors() until needed, since it initializes things */
       && (fg == COLOR_DEFAULT || bg == COLOR_DEFAULT || object == MT_COLOR_TREE) &&
       use_default_colors() != OK)