Remove unused parameters

* curs_main.c main_change_folder(flags)
* imap/imap.c imap_buffy_check(force)
* init.c mutt_nm_tag_complete(pos)
* ncrypt/crypt_gpgme.c verify_sender(protocol)
* recvcmd.c attach_forward_bodies(flags)
* mutt/file.c mutt_file_lock(path)
* mutt/file.c mutt_file_unlock(path)
* recvcmd.c mutt_attach_bounce(hdr)
* recvcmd.c mutt_attach_resend(hdr)
* recvcmd.c attach_forward_msgs(hdr)
* recvcmd.c attach_include_reply(flags)
* send.c mutt_make_misc_reply_headers(hdr,ctx)
* sendlib.c encode_8bit(istext)

attach.h

@@ -87,10 +87,8 @@ void mutt_pipe_attachment_list(struct AttachCtx *actx, FILE *fp, bool tag,
 void mutt_print_attachment_list(struct AttachCtx *actx, FILE *fp, bool tag,
                                 struct Body *top);
 
-void mutt_attach_bounce(FILE *fp, struct Header *hdr, struct AttachCtx *actx,
-                        struct Body *cur);
-void mutt_attach_resend(FILE *fp, struct Header *hdr, struct AttachCtx *actx,
-                        struct Body *cur);
+void mutt_attach_bounce(FILE *fp, struct AttachCtx *actx, struct Body *cur);
+void mutt_attach_resend(FILE *fp, struct AttachCtx *actx, struct Body *cur);
 void mutt_attach_forward(FILE *fp, struct Header *hdr, struct AttachCtx *actx,
                          struct Body *cur, int flags);
 void mutt_attach_reply(FILE *fp, struct Header *hdr, struct AttachCtx *actx,

buffy.c

@@ -726,7 +726,7 @@ int mutt_buffy_check(bool force)
   BuffyNotify = 0;
 
 #ifdef USE_IMAP
-  BuffyCount += imap_buffy_check(force, check_stats);
+  BuffyCount += imap_buffy_check(check_stats);
 #endif
 
   /* check device ID and serial number instead of comparing paths */

compress.c

@@ -96,7 +96,7 @@ static int lock_realpath(struct Context *ctx, int excl)
     return 0;
   }
 
-  int r = mutt_file_lock(ctx->realpath, fileno(ci->lockfp), excl, 1);
+  int r = mutt_file_lock(fileno(ci->lockfp), excl, 1);
 
   if (r == 0)
     ci->locked = 1;
@@ -128,7 +128,7 @@ static void unlock_realpath(struct Context *ctx)
   if (!ci->locked)
     return;
 
-  mutt_file_unlock(ctx->realpath, fileno(ci->lockfp));
+  mutt_file_unlock(fileno(ci->lockfp));
 
   ci->locked = 0;
   mutt_file_fclose(&ci->lockfp);

curs_main.c

@@ -435,8 +435,8 @@ void update_index(struct Menu *menu, struct Context *ctx, int check, int oldcoun
     menu->current = ci_first_message();
 }
 
-static int main_change_folder(struct Menu *menu, int op, char *buf, size_t bufsz,
-                              int *oldcount, int *index_hint, int flags)
+static int main_change_folder(struct Menu *menu, int op, char *buf,
+                              size_t bufsz, int *oldcount, int *index_hint)
 {
 #ifdef USE_NNTP
   if (option(OPT_NEWS))
@@ -1978,7 +1978,7 @@ int mutt_index_menu(void)
         if (!nm_uri_from_query(Context, buf, sizeof(buf)))
           mutt_message(_("Failed to create query, aborting."));
         else
-          main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint, 0);
+          main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint);
         break;
 
       case OP_MAIN_WINDOWED_VFOLDER_BACKWARD:
@@ -1998,7 +1998,7 @@ int mutt_index_menu(void)
         if (!nm_uri_from_query(Context, buf, sizeof(buf)))
           mutt_message(_("Failed to create query, aborting."));
         else
-          main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint, 0);
+          main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint);
         break;
 
       case OP_MAIN_WINDOWED_VFOLDER_FORWARD:
@@ -2019,7 +2019,7 @@ int mutt_index_menu(void)
         else
         {
           mutt_debug(2, "nm: + windowed query (%s)\n", buf);
-          main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint, 0);
+          main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint);
         }
         break;
 
@@ -2142,7 +2142,7 @@ int mutt_index_menu(void)
           }
         }
 
-        main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint, flags);
+        main_change_folder(menu, op, buf, sizeof(buf), &oldcount, &index_hint);
 #ifdef USE_NNTP
         /* mutt_buffy_check() must be done with mail-reader mode! */
         menu->help = mutt_compile_help(

enter.c

@@ -623,7 +623,7 @@ int mutt_enter_string_full(char *buf, size_t buflen, int col, int flags, int mul
           {
             mutt_mb_wcstombs(buf, buflen, state->wbuf, state->curpos);
             i = strlen(buf);
-            if (!mutt_nm_tag_complete(buf, buflen, i, state->tabs))
+            if (!mutt_nm_tag_complete(buf, buflen, state->tabs))
               BEEP();
 
             replace_part(state, 0, buf);

hcache/bdb.c

@@ -91,7 +91,7 @@ static void *hcache_bdb_open(const char *path)
     return NULL;
   }
 
-  if (mutt_file_lock(ctx->lockfile, ctx->fd, 1, 5))
+  if (mutt_file_lock(ctx->fd, 1, 5))
     goto fail_close;
 
   ret = db_env_create(&ctx->env, 0);
@@ -124,7 +124,7 @@ static void *hcache_bdb_open(const char *path)
 fail_env:
   ctx->env->close(ctx->env, 0);
 fail_unlock:
-  mutt_file_unlock(ctx->lockfile, ctx->fd);
+  mutt_file_unlock(ctx->fd);
 fail_close:
   close(ctx->fd);
   unlink(ctx->lockfile);
@@ -199,7 +199,7 @@ static void hcache_bdb_close(void **vctx)
 
   ctx->db->close(ctx->db, 0);
   ctx->env->close(ctx->env, 0);
-  mutt_file_unlock(ctx->lockfile, ctx->fd);
+  mutt_file_unlock(ctx->fd);
   close(ctx->fd);
   unlink(ctx->lockfile);
   FREE(vctx);

imap/imap.c

@@ -1472,7 +1472,7 @@ int imap_check(struct ImapData *idata, int force)
  * batch the commands and save on round trips. Returns number of mailboxes with
  * new mail.
  */
-int imap_buffy_check(int force, int check_stats)
+int imap_buffy_check(int check_stats)
 {
   struct ImapData *idata = NULL;
   struct ImapData *lastdata = NULL;

imap/imap.h

@@ -68,7 +68,7 @@ int imap_access(const char *path);
 int imap_check_mailbox(struct Context *ctx, int force);
 int imap_delete_mailbox(struct Context *ctx, struct ImapMbox *mx);
 int imap_sync_mailbox(struct Context *ctx, int expunge);
-int imap_buffy_check(int force, int check_stats);
+int imap_buffy_check(int check_stats);
 int imap_status(char *path, int queue);
 int imap_search(struct Context *ctx, const struct Pattern *pat);
 int imap_subscribe(char *path, bool subscribe);

init.c

@@ -3737,7 +3737,7 @@ bool mutt_nm_query_complete(char *buffer, size_t len, int pos, int numtabs)
  *
  * Complete the nearest "+" or "-" -prefixed string previous to pos.
  */
-bool mutt_nm_tag_complete(char *buffer, size_t len, int pos, int numtabs)
+bool mutt_nm_tag_complete(char *buffer, size_t len, int numtabs)
 {
   if (!buffer)
     return false;

mbox.c

@@ -74,7 +74,7 @@ static int mbox_lock_mailbox(struct Context *ctx, int excl, int retry)
 {
   int r;
 
-  r = mutt_file_lock(ctx->path, fileno(ctx->fp), excl, retry);
+  r = mutt_file_lock(fileno(ctx->fp), excl, retry);
   if (r == 0)
     ctx->locked = true;
   else if (retry && !excl)
@@ -92,7 +92,7 @@ static void mbox_unlock_mailbox(struct Context *ctx)
   {
     fflush(ctx->fp);
 
-    mutt_file_unlock(ctx->path, fileno(ctx->fp));
+    mutt_file_unlock(fileno(ctx->fp));
     ctx->locked = false;
   }
 }
@@ -496,7 +496,7 @@ static int mbox_close_mailbox(struct Context *ctx)
 
   if (ctx->append)
   {
-    mutt_file_unlock(ctx->path, fileno(ctx->fp));
+    mutt_file_unlock(fileno(ctx->fp));
     mutt_sig_unblock();
   }
 

mutt/file.c

@@ -1089,7 +1089,6 @@ int mutt_file_chmod_rm_stat(const char *path, mode_t mode, struct stat *st)
 
 /**
  * mutt_file_lock - (try to) lock a file
- * @param path    Path to file
  * @param fd      File descriptor to file
  * @param excl    If set, try to lock exclusively
  * @param timeout Retry after this time
@@ -1101,7 +1100,7 @@ int mutt_file_chmod_rm_stat(const char *path, mode_t mode, struct stat *st)
  *
  * Use mutt_file_unlock() to unlock the file.
  */
-int mutt_file_lock(const char *path, int fd, int excl, int timeout)
+int mutt_file_lock(int fd, int excl, int timeout)
 {
 #if defined(USE_FCNTL) || defined(USE_FLOCK)
   int count;
@@ -1201,11 +1200,10 @@ int mutt_file_lock(const char *path, int fd, int excl, int timeout)
 
 /**
  * mutt_file_unlock - Unlock a file previously locked by mutt_file_lock()
- * @param path Path to file
- * @param fd   File descriptor to file
+ * @param fd File descriptor to file
  * @retval 0 Always
  */
-int mutt_file_unlock(const char *path, int fd)
+int mutt_file_unlock(int fd)
 {
 #ifdef USE_FCNTL
   struct flock unlockit = { F_UNLCK, 0, 0, 0, 0 };
@@ -1236,7 +1234,7 @@ void mutt_file_unlink_empty(const char *path)
   if (fd == -1)
     return;
 
-  if (mutt_file_lock(path, fd, 1, 1) == -1)
+  if (mutt_file_lock(fd, 1, 1) == -1)
   {
     close(fd);
     return;
@@ -1245,7 +1243,7 @@ void mutt_file_unlink_empty(const char *path)
   if (fstat(fd, &sb) == 0 && sb.st_size == 0)
     unlink(path);
 
-  mutt_file_unlock(path, fd);
+  mutt_file_unlock(fd);
   close(fd);
 }
 

mutt/file.h

@@ -49,7 +49,7 @@ const char *mutt_file_dirname(const char *p);
 int         mutt_file_fclose(FILE **f);
 FILE *      mutt_file_fopen(const char *path, const char *mode);
 int         mutt_file_fsync_close(FILE **f);
-int         mutt_file_lock(const char *path, int fd, int excl, int timeout);
+int         mutt_file_lock(int fd, int excl, int timeout);
 int         mutt_file_mkdir(const char *path, mode_t mode);
 int         mutt_file_open(const char *path, int flags);
 size_t      mutt_file_quote_filename(char *d, size_t l, const char *f);
@@ -66,6 +66,6 @@ int         mutt_file_to_absolute_path(char *path, const char *reference);
 void        mutt_file_touch_atime(int f);
 void        mutt_file_unlink(const char *s);
 void        mutt_file_unlink_empty(const char *path);
-int         mutt_file_unlock(const char *path, int fd);
+int         mutt_file_unlock(int fd);
 
 #endif /* _MUTT_FILE_H */

ncrypt/crypt_gpgme.c

@@ -5034,7 +5034,7 @@ int smime_gpgme_send_menu(struct Header *msg)
   return gpgme_send_menu(msg, 1);
 }
 
-static int verify_sender(struct Header *h, gpgme_protocol_t protocol)
+static int verify_sender(struct Header *h)
 {
   struct Address *sender = NULL;
   unsigned int rc = 1;
@@ -5114,7 +5114,7 @@ static int verify_sender(struct Header *h, gpgme_protocol_t protocol)
 
 int smime_gpgme_verify_sender(struct Header *h)
 {
-  return verify_sender(h, GPGME_PROTOCOL_CMS);
+  return verify_sender(h);
 }
 
 void mutt_gpgme_set_sender(const char *sender)

newsrc.c

@@ -124,7 +124,7 @@ void nntp_newsrc_close(struct NntpServer *nserv)
     return;
 
   mutt_debug(1, "Unlocking %s\n", nserv->newsrc_file);
-  mutt_file_unlock(nserv->newsrc_file, fileno(nserv->newsrc_fp));
+  mutt_file_unlock(fileno(nserv->newsrc_fp));
   mutt_file_fclose(&nserv->newsrc_fp);
 }
 
@@ -188,7 +188,7 @@ int nntp_newsrc_parse(struct NntpServer *nserv)
 
   /* lock it */
   mutt_debug(1, "Locking %s\n", nserv->newsrc_file);
-  if (mutt_file_lock(nserv->newsrc_file, fileno(nserv->newsrc_fp), 0, 1))
+  if (mutt_file_lock(fileno(nserv->newsrc_fp), 0, 1))
   {
     mutt_file_fclose(&nserv->newsrc_fp);
     return -1;

pager.c

@@ -2710,7 +2710,7 @@ int mutt_pager(const char *banner, const char *fname, int flags, struct Pager *e
         CHECK_MODE(IsHeader(extra) || IsMsgAttach(extra))
         CHECK_ATTACH;
         if (IsMsgAttach(extra))
-          mutt_attach_bounce(extra->fp, extra->hdr, extra->actx, extra->bdy);
+          mutt_attach_bounce(extra->fp, extra->actx, extra->bdy);
         else
           ci_bounce_message(extra->hdr);
         break;
@@ -2719,7 +2719,7 @@ int mutt_pager(const char *banner, const char *fname, int flags, struct Pager *e
         CHECK_MODE(IsHeader(extra) || IsMsgAttach(extra))
         CHECK_ATTACH;
         if (IsMsgAttach(extra))
-          mutt_attach_resend(extra->fp, extra->hdr, extra->actx, extra->bdy);
+          mutt_attach_resend(extra->fp, extra->actx, extra->bdy);
         else
           mutt_resend_message(NULL, extra->ctx, extra->hdr);
         pager_menu->redraw = REDRAW_FULL;

protos.h

@@ -196,7 +196,7 @@ void mutt_check_lookup_list(struct Body *b, char *type, int len);
 void mutt_make_attribution(struct Context *ctx, struct Header *cur, FILE *out);
 void mutt_make_forward_subject(struct Envelope *env, struct Context *ctx, struct Header *cur);
 void mutt_make_help(char *d, size_t dlen, const char *txt, int menu, int op);
-void mutt_make_misc_reply_headers(struct Envelope *env, struct Context *ctx, struct Header *cur, struct Envelope *curenv);
+void mutt_make_misc_reply_headers(struct Envelope *env, struct Envelope *curenv);
 void mutt_make_post_indent(struct Context *ctx, struct Header *cur, FILE *out);
 void mutt_message_to_7bit(struct Body *a, FILE *fp);
 void mutt_mktemp_full(char *s, size_t slen, const char *prefix, const char *suffix, const char *src, int line);
@@ -257,7 +257,7 @@ int mutt_command_complete(char *buffer, size_t len, int pos, int numtabs);
 int mutt_var_value_complete(char *buffer, size_t len, int pos);
 #ifdef USE_NOTMUCH
 bool mutt_nm_query_complete(char *buffer, size_t len, int pos, int numtabs);
-bool mutt_nm_tag_complete(char *buffer, size_t len, int pos, int numtabs);
+bool mutt_nm_tag_complete(char *buffer, size_t len, int numtabs);
 #endif
 int mutt_complete(char *s, size_t slen);
 int mutt_compose_attachment(struct Body *a);

recvattach.c

@@ -1350,14 +1350,14 @@ void mutt_view_attachments(struct Header *hdr)
 
       case OP_RESEND:
         CHECK_ATTACH;
-        mutt_attach_resend(CURATTACH->fp, hdr, actx,
+        mutt_attach_resend(CURATTACH->fp, actx,
                            menu->tagprefix ? NULL : CURATTACH->content);
         menu->redraw = REDRAW_FULL;
         break;
 
       case OP_BOUNCE_MESSAGE:
         CHECK_ATTACH;
-        mutt_attach_bounce(CURATTACH->fp, hdr, actx,
+        mutt_attach_bounce(CURATTACH->fp, actx,
                            menu->tagprefix ? NULL : CURATTACH->content);
         menu->redraw = REDRAW_FULL;
         break;