Ticl em vs had bdt #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rovere
reviewed
Dec 6, 2019
| reader_->AddVariable("ts_pcasig2", &ts_pcasig2); | ||
|
|
||
| std::string CMSSW_BASE(std::getenv("CMSSW_BASE")); | ||
| std::string weightfilename_ = CMSSW_BASE+"/src/RecoHGCal/data/em_vs_had_xgboost.xml"; |
There was a problem hiding this comment.
Why not trying the usual FileInPath approach?
See, e.g., FWCore/ParameterSet/interface/FileInPath.h
There is also the corresponding python parameter cms.FileInPath.
If you git grep FileInPath in CMSSW, you will find plenty of examples.
| @@ -36,6 +40,9 @@ namespace ticl { | |||
| const int eidNLayers_; | |||
| const int eidNClusters_; | |||
|
|
|||
| TMVA::Reader* reader_; | |||
| float ts_energy, ts_x, ts_y, ts_z, ts_pcaeigval0, ts_pcasig0, ts_pcaeigval1, ts_pcasig1, ts_pcaeigval2, ts_pcasig2; | |||
There was a problem hiding this comment.
Private variables should always be terminated by an underscore character: _, so that people reading code can understand where they are coming from.
|
|
||
| float mva_ = 1.; | ||
| for (unsigned int itrkster = 0; itrkster<tracksters.size(); ++itrkster) { | ||
| ts_energy = tracksters.at(itrkster).raw_energy; |
There was a problem hiding this comment.
I'm not sure I like the approach of having private variables dedicated to run BDT inference.
I'll think a bit more about that.
rovere
pushed a commit
that referenced
this pull request
Nov 27, 2020
Fixing I/O rules for ScoutingMuon backward accessibility
rovere
pushed a commit
that referenced
this pull request
Jun 15, 2023
Recover fillDescriptions as requested
rovere
pushed a commit
that referenced
this pull request
May 6, 2024
* remove comments, set constants constant * remove CASTOR cleaner and merger * Remove single generator customize function. It is not used anymore since the generator step is splitted in 3 steps. * remove unneeded filters * optimize embedding correction calculation * optimize selector loops * format cpp code with scram build code-format --------- Co-authored-by: cwinter <[email protected]>
rovere
pushed a commit
that referenced
this pull request
Aug 19, 2024
Update prompt and displaced muon names to reflect GMT changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit of a BDT to separate EM and HAD showers in TICL
This PR adds float to the Trackster object which is the BDT score
The weights file is kind of dummy - will be updated in the next few days.