Added tests for all sync methods on telegram #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For testing the async methods you can take a look at pytest-asyncio. |
rougeth
reviewed
Oct 12, 2017
| def test_telegram_engine_define_new_mode(): | ||
| '''Make sure TelegramEngine supports new modes.''' | ||
| engine = TelegramEngine(token='', mode='else') | ||
| assert engine.mode == 'else' |
There was a problem hiding this comment.
Actually, what should be tested is if no mode is passed to TelegramEngine, its default mode will be polling, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not close all #51 because I don't know how to test async methods.