Testing & refactoring in progress

rotexsoft · Dec 8, 2023 · c7de18f · c7de18f
1 parent 8cb3d99
commit c7de18f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/controllers/BaseController.php b/src/controllers/BaseController.php
@@ -636,7 +636,7 @@ public function actionLogin() {
             if( ($error_msg === '') ) {
 
                 $credentials = [
-                    'username'=> filter_var($username, FILTER_SANITIZE_STRING),
+                    'username'=> filter_var($username, FILTER_UNSAFE_RAW),
                     'password'=> $password, //Not sanitizing this. Sanitizing or
                                             //validating passwords should be app
                                             //specific & done during user creation. 

diff --git a/tests/BaseControllerTest.php b/tests/BaseControllerTest.php
@@ -1127,6 +1127,9 @@ public function testThat_doLogin_WorksAsExpected() {
             $psr11Container, 'da-controller', 'da-action', $req, $resp
         );
 
+        ////////////////////////////////////////////////////////////////////////
+        ////////////////////////////////////////////////////////////////////////
+
         $success_redirect_path = '/random-path';
         $expected_redirect_path = 
             $_SESSION[\SMVCTools\Tests\TestObjects\ControllerWithPublicDoLogin::SESSN_PARAM_LOGIN_REDIRECT];