Better support for the reply-ack mechanism #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reply-ack mechanism is intended to be backwards compatible with APRS 1.01. The current implementation of reply-ack parsing makes it difficult to ack messages sent from clients that support reply-ack.
There are three rules in
reply-ack
that require the entire string after the{
to be accessible.http://www.aprs.org/aprs11/replyacks.txt
If we look at the parsed data, we will see that following rule 4 is a little difficult. Aside from looking at the
raw
value, there's nothing that indicates that I should sendackMU}
instead ofackMU
when acknowledging this message according to rule 4.This change modifies the parsed data in the following way:
msgNo101
is the full string of the message number as if it was parsed by an APRS 1.01 client. This allows us to easily ack the message by just following rule 4 with themsgNo101
value.isReplyAck
tells us that the client that sent the message supports reply-ack. This tells an application to follow rule 3 for deduping and that the application can use the reply-ack mechanism for acknowledgments.