Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination of various HVAC PRs #1793

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

apbarratt
Copy link

@apbarratt apbarratt commented Sep 16, 2024

A quick explanation:

This PR compiles the work of eight different PRs, allowing @rospogrigio to close seven of them in one go.
These are all PRs that allow for the mapping of various found HVAC modes, statuses and presets.

Three of the PRs were found to have already been implemented.

I have not included PRs that contained any changes or additions to logic, with the exception of one, in which I have only included the discovered modes, but not the logic changes suggested, which were good, but require more work before being workable.

I have also taken steps to make it clear when statuses are only applyable to heating or cooling only devices. For example, "manual vs auto" could apply to cooling or heating devices, but it was not clear that in most cases we were only supporting heating devices. This should not be more intuitive in the config screen.

Included changes:

heat/cool/auto
With thanks to @Leifex
#1517

home/leave/auto
With thanks to @fmobile999
#1741

1/0 for current hvac mode
With thanks to @kastmgnru and @Gurutasker
#1543
#1064

True/False and cooling/no_cooling for AC options
With thanks to @dubyatp. I've added these modes, but more work will be needed to use the rest of their cooling work, so I wouldn't recommend closing the following PR just yet.
#888

PRs found to already be implemented:

Thanks to @eturfboer, @jreenen and @bramvandenbussche for these too. It seems they've been implemented since your original PRs came along now.
#1351
#1352
#1684

Future work

As has been suggested in the past, eventually we will ditch all these presets and have a free text input field for options (with maybe a few suggested values for what we are already aware of). But in the mean time, we might as well get what people have suggested merged in whilst we know it won't cause any harm in adding them and hopefully clear up some of this PR backlog in the process :)

@apbarratt
Copy link
Author

Noted I accidentally broke master in my last commit too with an old constant that has been removed in previous work. I've added a fix for this here. #1794

@apbarratt
Copy link
Author

Tested and confirmed to be loading and working on Home Assistant Core 2024.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant