Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick explanation:
This PR compiles the work of eight different PRs, allowing @rospogrigio to close seven of them in one go.
These are all PRs that allow for the mapping of various found HVAC modes, statuses and presets.
Three of the PRs were found to have already been implemented.
I have not included PRs that contained any changes or additions to logic, with the exception of one, in which I have only included the discovered modes, but not the logic changes suggested, which were good, but require more work before being workable.
I have also taken steps to make it clear when statuses are only applyable to heating or cooling only devices. For example, "manual vs auto" could apply to cooling or heating devices, but it was not clear that in most cases we were only supporting heating devices. This should not be more intuitive in the config screen.
Included changes:
heat/cool/auto
With thanks to @Leifex
#1517
home/leave/auto
With thanks to @fmobile999
#1741
1/0
for current hvac modeWith thanks to @kastmgnru and @Gurutasker
#1543
#1064
True/False
andcooling/no_cooling
for AC optionsWith thanks to @dubyatp. I've added these modes, but more work will be needed to use the rest of their cooling work, so I wouldn't recommend closing the following PR just yet.
#888
PRs found to already be implemented:
Thanks to @eturfboer, @jreenen and @bramvandenbussche for these too. It seems they've been implemented since your original PRs came along now.
#1351
#1352
#1684
Future work
As has been suggested in the past, eventually we will ditch all these presets and have a free text input field for options (with maybe a few suggested values for what we are already aware of). But in the mean time, we might as well get what people have suggested merged in whilst we know it won't cause any harm in adding them and hopefully clear up some of this PR backlog in the process :)