Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

246 fix error when invalid waterways geometry #247

Merged
merged 16 commits into from
Feb 23, 2024
Merged

246 fix error when invalid waterways geometry #247

merged 16 commits into from
Feb 23, 2024

Conversation

rosepearson
Copy link
Owner

@rosepearson rosepearson commented Feb 22, 2024 •
edited
Loading

Fixes:

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson
Fix error when invalid geometries
bc2a828
@rosepearson
Update dem.py
1df29f4 
Explicitly delete the DEM between save and load to encourage Python to release the file.
@rosepearson
Add the option of not clipping in the raw dem generation
88a4b2a 
set this as default for the waterways step.
The thought is this may reduce processing load.
Hopefully produce fewer dask / garbage collection errors in waterways.
@rosepearson
Turn on file compression and check in tests
b5e6096
This was linked to issues Feb 22, 2024
fix error when invalid waterways geometry #246
Closed
Compress output NetCDF files #236
Closed
github-actions and others added 12 commits February 22, 2024 21:12
fixup: Format Python code with Black
2b3e7a5
@rosepearson
Update version
45df5c6
@rosepearson
set compression when saving file but not for final output
1a3e6f9
fixup: Format Python code with Black
70b9407
@rosepearson
tidy up
e619756
@rosepearson
Fixed compression errors
80ca96b
fixup: Format Python code with Black
bf7beff
@rosepearson
Merge branch '246-fix-error-when-invalid-waterways-geometry' of githu…
c5fc01a 
…b.com:rosepearson/GeoFabrics into 246-fix-error-when-invalid-waterways-geometry
@rosepearson
missed prom last commit
54a6692
@rosepearson
Merge branch '246-fix-error-when-invalid-waterways-geometry' of githu…
c1d2bcb 
…b.com:rosepearson/GeoFabrics into 246-fix-error-when-invalid-waterways-geometry
@rosepearson
Merge branch '246-fix-error-when-invalid-waterways-geometry' of githu…
3afdb6b 
…b.com:rosepearson/GeoFabrics into 246-fix-error-when-invalid-waterways-geometry
@rosepearson
updated benchmark
dafe294
@rosepearson rosepearson merged commit 2e07142 into main Feb 23, 2024
2 checks passed
@rosepearson rosepearson deleted the 246-fix-error-when-invalid-waterways-geometry branch February 23, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix error when invalid waterways geometry Compress output NetCDF files
1 participant
@rosepearson