-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
- Loading branch information
There are no files selected for viewing
4 comments
on commit e7ccaa3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall @rozeykex -- I'll push the output file from yesterday's simulations, though I suspect that they're now outdated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take that back -- simulations still running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking @bradduthie. I'm not forcing germination prob to 1 when seed survival == 0. Although it looks like that at first! Instead, when seed survival is 0 (so no ungerminated seeds will survive and therefore don't need genomes), I'm deciding the germination fate at the end of zygote creation with the correct germination probability. Then only those that are destined to germinate survive to become seeds and get genomes added, meaning I can allow all seeds to germinate in this case and it gives the same effect but reduces time to compute by 25%.
I think I referenced the wrong commit - the right one had some explanation of my thinking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your sims are probably not useful now though! I cancelled the other ones I had going yesterday, feel free to shut those ones off @bradduthie.
This looks fine @rozeykex -- though would the same be accomplished by setting
seed_survival_prob <- 0
andgermination_prob <- 1
(i.e., are you now forcing the latter when you set the former)?