[jazzy] Add PlayerClock::wakeup() to interrupt sleeping (backport #1869) #1875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
wakeup()
method toPlayerClock
. It wakes up the clock, which is (only) useful if it is currently sleeping, i.e., in asleep_until()
call. Just callingstd::condition_variable::notify_all()
on the clock's condition variable wakes it up from its sleep (i.e.,std::condition_variable::wait_for()
andstd::condition_variable::wait_until()
):This can then replace the current workaround in
Player::stop()
to force-wakeup the clock, which is to resume the clock and then immediately pause it. Since we don't actually want to pause the clock, doing this may have unintended consequences, e.g., if the player is woken up and then thinks it's not in pause mode anymore.I want to use this in #1848, but I thought a separate PR would be easier to review.
This is an automatic backport of pull request #1869 done by Mergify.