Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple bag player examples #1580
Add simple bag player examples #1580
Changes from 12 commits
b6b62a9
2ba6546
b2c9893
ed349be
2a2b97b
7f36044
21876b5
67fe8fb
cbac862
76f6b4b
6b276b1
c2e0716
6cfd645
1f53c6a
77eb62a
2ea7282
0690d6a
e172f35
8282371
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i am not mistaken, this is intentionally enabled as
sqlite3
? but this bag file can be also red fromsimple_bag_player.cpp
, because it reads the meta data from the bag file and use the appropriate storage plugin if available? just checking this because user does not meet the failure during the tutorial.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was set as
sqlite3
insimple_bag_recorder.py
. I don't know the reason exactly.It is possible to read
sqlite3
files fromsimple_bag_player.cpp
, but the opposite(readingmcap
files fromsimple_bag_player.py
) isn't.Maybe we can delete
storage_id
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, i think that is okay with current code. this also includes an example how to specify the storage id, i think that is fine.