Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RViz Marker DisplayTypes Tutorial (backport #4821) #4872

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 21, 2024

This PR is a continuation of the initial issue #3864, the discussion in the abandoned PR #3908 which led to the first completed PR #4040 of the porting of old RViz tutorial series.

This is the next tutorial about RViz and especially RViz Marker Types, which is the basis for the following tutorial series I want to port in later PRs as soon as this one is ready because I have some time now.

The link to the original Marker DisplayTypes Tutorial in ROS1 which served as a basis.

In the old RViz documentation page the DisplayTypes: Marker was grouped with the other DisplayTypes on a subpage. In contrast, I decided to keep it on the main RViz subpage for this version, as I do not intend to add new PRs for the other DisplayTypes in the near future. I want to finish the current tutorial series first. I do not think we need a subpage for the Marker DisplayTypes page until we have more than one other DisplayType Page, and I think this page still fits nicely into the main RViz page at the moment, but I am interested in your opinion.

I think this version is ready for your next review step (as it had one or two review steps in #3908)


This is an automatic backport of pull request #4821 done by Mergify.

Signed-off-by: Lewe Christiansen <[email protected]>
Co-authored-by: lewec <[email protected]>
(cherry picked from commit 8c6ae4a)
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11953212234/artifacts/2218540747.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4872/index.html in your favorite browser

@ahcorde ahcorde merged commit ff77833 into iron Nov 21, 2024
4 checks passed
@ahcorde ahcorde deleted the mergify/bp/iron/pr-4821 branch November 21, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants