Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf2 listener cpp tutorial: minor syntax/wording improvements (backport #4434) #4461

Merged
merged 1 commit into from
May 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 15, 2024

some changes i think might improve readability, as discovered in osrf/ros2_test_cases#1176.
i would have liked to add a link to a more generic "tf concepts" page, but i didnt find anything satisfactory. i really like tho the first two paragraphs in #4235 which i found very insightful especially around the question of target/source terminology and frame order.


This is an automatic backport of pull request #4434 done by Mergify.

@mergify mergify bot requested a review from clalancette as a code owner May 15, 2024 19:17
@mergify mergify bot added the conflicts label May 15, 2024
@mergify mergify bot requested a review from audrow as a code owner May 15, 2024 19:17
Copy link
Contributor Author

mergify bot commented May 15, 2024

Cherry-pick of bfbd9bc has failed:

On branch mergify/bp/iron/pr-4434
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit bfbd9bc4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

* tf2 listener cpp tutorial: minor syntax/wording improvements

* add link to tf2 concepts page

(cherry picked from commit bfbd9bc)

# Conflicts:
#	source/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Listener-Cpp.rst
@clalancette clalancette merged commit 047b9f0 into iron May 15, 2024
4 checks passed
@clalancette clalancette deleted the mergify/bp/iron/pr-4434 branch May 15, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants