-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft of velocity transform specification #4235
Open
ahcorde
wants to merge
8
commits into
rolling
Choose a base branch
from
tf_velocity
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
54822c6
Add draft of velocity transform specification
tfoote 84d2e89
Merge remote-tracking branch 'origin/rolling' into tf_velocity
ahcorde 3e9d8b6
Merge remote-tracking branch 'origin/rolling' into tf_velocity
ahcorde b7692b4
make linters happy'
ahcorde 517535b
spelling
ahcorde 69c11bb
feedback
ahcorde 345cc28
Merge remote-tracking branch 'origin/rolling' into tf_velocity
ahcorde e4e6af5
Feedback
ahcorde File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the reference and moving frames of the two velocities have to satisfy some constraint? The example below makes sense in that we're saying add the velocity of A relative to B and velocity of B relative to C to get velocity of A relative to C. But if B wasn't the reference frame in the first term and the moving frame in the second term, e.g., the moving frame in the second term was D, the end result would not be meaningful.
i.e, what would be the result of
V_{Obs}^{A - B} + V_{Obs}^{D - C}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahcorde I didn't mean to request that this be changed to
V_{Obs}^{D - C}
. I was asking if we need to clarify this more since I didn't think it's sufficient to just say the observation frames must be the same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The velocity of a point, as seen from two different frames, must also include the relative angular velocity vector between the two frames, but I think that is not handled here, right?
PS: I mean, the classic kinematics formula:$v_B = v_A + \omega \times (AB)$
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlblancoc Yes, this is covered by the requirement that they're observed from the same frame. If you have velocities in a different observation frame, it will include those additional terms to put it into the same observational frame.
@azeey You're right that differencing two velocities that don't share a frame(referrence or moving) is not semantically meaningful. I think that we currently don't enforce the constraints on the lower level math primatives such as vectors and leave this to the users to make sure they do appropriate semantic math. I would love to extend and provide a way to enforce that. But that's more for the linear math library rather than what we're adding on top. And that's also likely a very big effort that I'm not sure we're ready to put into developing.