Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rosdep: 1) Friendlier to beginners, 2) Clarifying rosdep is ROS-agnostic (backport #3719) #3821

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 4, 2023

This is an automatic backport of pull request #3719 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…OS-agnostic (#3719)

* Improve: rosdep

- Avoid giving an impression that `rosdep` is ros-dependent. It is actually widely applicable than ROS projects.
   - This matters IMO where the development involves non-ROS environment e.g. corporate, where people tend to end up inventing their own dependency management framework that runs alongside of `rosdep`, resulted in `rosdep` not being contributed.
- Trying to make it friendlier to non-expert readers by clarifyig `rosdistro` website and some jargons.
- Explanation of `<*depend>` is missing in ros2 doc set. Something detailed like http://docs.ros.org/en/melodic/api/catkin/html/howto/format2/catkin_library_dependencies.html
   - Thought I'd add those in here but ran out of time. I don't know if rosdep page is the best for such info anyways.

* Improve: rosdep: Add link to detail about the types of dependency

Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
(cherry picked from commit 00e2140)
@clalancette clalancette merged commit d965ea0 into humble Aug 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/humble/pr-3719 branch August 4, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants