-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GraphCache for services & clients along with remaining graph introspection methods #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
force-pushed
the
yadu/service_introspection
branch
from
January 4, 2024 16:15
33c1bdd
to
61b4126
Compare
Yadunund
changed the base branch from
francocipollone/service_support_via_queryable
to
rolling
January 12, 2024 03:33
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/service_introspection
branch
from
January 12, 2024 13:19
5c6f26b
to
26fca70
Compare
Signed-off-by: Yadunund <[email protected]>
clalancette
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few things to think about, but overall I think this is pretty good. I have a whole bunch of fixes to go on top of this, so hopefully we can get this cleaned up and merged soon.
4 tasks
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Yadu <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Yadu <[email protected]>
Signed-off-by: Yadunund <[email protected]>
clalancette
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #86 but with changes from #87. Reviewing might be easier if we merge #87 in and rebase #86.Changes introduced:
/
in the middle. Eg/add_two_ints_server/get_type_description
. Previously such names would get appended to the liveliness token without any substitution which could cause the parsing and reconstruction ofliveliness::Entity
to have incorrect values for types and qos. Now aSLASH_REPLACEMENT
char is introduced and such names and mangled and demangled to correctly transmit and reconstruct graph information.To Test:
# terminal 1 ros2 run demo_nodes_cpp add_two_ints_server
ros2 node info /add_two_ints # result /add_two_ints_server Subscribers: /parameter_events: rcl_interfaces/msg/ParameterEvent Publishers: /rosout: rcl_interfaces/msg/Log /parameter_events: rcl_interfaces/msg/ParameterEvent Service Servers: /add_two_ints_server/get_type_description: type_description_interfaces/srv/GetTypeDescription /add_two_ints: example_interfaces/srv/AddTwoInts /add_two_ints_server/get_parameter_types: rcl_interfaces/srv/GetParameterTypes /add_two_ints_server/list_parameters: rcl_interfaces/srv/ListParameters /add_two_ints_server/get_parameters: rcl_interfaces/srv/GetParameters /add_two_ints_server/describe_parameters: rcl_interfaces/srv/DescribeParameters /add_two_ints_server/set_parameters_atomically: rcl_interfaces/srv/SetParametersAtomically /add_two_ints_server/set_parameters: rcl_interfaces/srv/SetParameters Service Clients: Action Servers: Action Clients:
Known issue (currently being investigated)
Starting 3 or more nodes causes the liveliness get query at node initialization to hang indefinitely.