Switch to liveliness tokens #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
force-pushed
the
yadu/liveliness
branch
from
2bbe95a to
bd2c015
Compare
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/liveliness
branch
from
bd2c015 to
c6bc79b
Compare
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/liveliness
branch
from
66ee215 to
9e622d7
Compare
|
Issues resolved by switching to |
clalancette
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Switch to liveliness tokens Signed-off-by: Yadunund <[email protected]> * Use zc APIs instead of macros to resolve liveliness api issues Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]>
Yadunund
added a commit
that referenced
this pull request
Nov 19, 2023
* Add storage plugin config to router config Signed-off-by: Yadunund <[email protected]> * Fix non empty node namespace Signed-off-by: Yadunund <[email protected]> * Rely on unordered_map instead of yaml for graph cache Signed-off-by: Yadunund <[email protected]> * Update graph cache with publisher data Signed-off-by: Yadunund <[email protected]> * Implement basic publisher introspection Signed-off-by: Yadunund <[email protected]> * Switch to liveliness tokens (#67) * Switch to liveliness tokens Signed-off-by: Yadunund <[email protected]> * Use zc APIs instead of macros to resolve liveliness api issues Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> * Cleanup yaml-cpp Signed-off-by: Yadunund <[email protected]> * Cleanup previous graph cache impl Signed-off-by: Yadunund <[email protected]> * Refactor topic cache Signed-off-by: Yadunund <[email protected]> * Implement liveliness tokens for subscriptions and update graph Signed-off-by: Yadunund <[email protected]> * Fix types and type mangling. When playing around with this I found that the types weren't being properly filled in, and also weren't being demangled. Fix both of those things here, as well as do a lot of cleanup. Signed-off-by: Chris Lalancette <[email protected]> * Update README Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Yadunund
added a commit
that referenced
this pull request
Jan 12, 2024
* Add storage plugin config to router config Signed-off-by: Yadunund <[email protected]> * Fix non empty node namespace Signed-off-by: Yadunund <[email protected]> * Rely on unordered_map instead of yaml for graph cache Signed-off-by: Yadunund <[email protected]> * Update graph cache with publisher data Signed-off-by: Yadunund <[email protected]> * Implement basic publisher introspection Signed-off-by: Yadunund <[email protected]> * Switch to liveliness tokens (#67) * Switch to liveliness tokens Signed-off-by: Yadunund <[email protected]> * Use zc APIs instead of macros to resolve liveliness api issues Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> * Cleanup yaml-cpp Signed-off-by: Yadunund <[email protected]> * Cleanup previous graph cache impl Signed-off-by: Yadunund <[email protected]> * Refactor topic cache Signed-off-by: Yadunund <[email protected]> * Implement liveliness tokens for subscriptions and update graph Signed-off-by: Yadunund <[email protected]> * Fix types and type mangling. When playing around with this I found that the types weren't being properly filled in, and also weren't being demangled. Fix both of those things here, as well as do a lot of cleanup. Signed-off-by: Chris Lalancette <[email protected]> * Update README Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the discovery mechanism to rely on liveliness tokens instead of put/del/get commands which also relied on configuring the router with a storage plugin.
A neat outcome of relying on liveliness tokens is that we no longer need to pass
--no-daemonto any CLI introspection tooling.Edit: issues were resolved by 9e622d7
However during testing I observe the following issues:
z_checkmacro withzc_owned_liveliness_token: Unable to build despite macro available inzenoh_macros.hz_drop(z_move(zc_owned_liveliness_token_t))orz_drop(z_move(zc_owned_liveliness_subscriber_options_t))which demangles to