Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the C++ code #344

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Updates to the C++ code #344

merged 5 commits into from
Dec 17, 2024

Conversation

clalancette
Copy link
Collaborator

This is a series of relatively small updates to the zenoh-cpp port. In particular:

  1. Change the storage of the GID from a std::vector to a std::array, since it is always a fixed size.
  2. Remove the now completely unnecessary ClientData init method; we can do all of the work in the constructor.
  3. Do a bunch of really small refactorings.
  4. Fix a bad string print in rmw_service_data.cpp
  5. Rewrite how we connect to the router so that it only prints when we fail.

With this in place, I'm now happy with the state of #327. @ahcorde FYI

@clalancette
Switch to storing GIDs with a std::array.
fafeb28 
They are a fixed size, so should use the fixed-size data
structure.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Remove unnecessary ClientData init() method.
d57940e 
Since we aren't calling shared_from_this() in it anymore,
we can do all of the work in the constructor.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Small refactorings.
93bf722 
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Fix bad string print.
afe1ff9 
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette
Rewrite connecting to the router to only print when it fails.
c046a5e 
This simplifies the code, and makes it less noisy.

Signed-off-by: Chris Lalancette <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 17, 2024

thank you for the updates 👍

@clalancette clalancette merged commit b2b76e0 into ahcorde/dev/1.0.0-cpp Dec 17, 2024
6 checks passed
@clalancette clalancette deleted the clalancette/cpp-updates branch December 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clalancette @ahcorde