Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rmw_publisher_assert_liveliness #235

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Implement rmw_publisher_assert_liveliness #235

merged 1 commit into from
Jul 2, 2024

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Jul 2, 2024

With the changes here, I'm able to get rcl/test_publisher to pass.

@Yadunund Yadunund requested a review from clalancette July 2, 2024 18:56
clalancette
clalancette approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@Yadunund Yadunund merged commit 9ede38d into rolling Jul 2, 2024
8 checks passed
@Yadunund Yadunund deleted the yadu/rmw_publisher_assert_liveliness branch July 2, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yadunund @clalancette