Implement rmw_take_sequence. #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this isn't currently used by rclcpp and rclpy, it *is* used inside of rcl, specifically in testing. Thus we need to implement it to pass all rcl tests. To reduce code duplication, this commit refactors __rmw_take() to handle this case. In particular, we rename __rmw_take() to __rmw_take_one(), with no error checking. Then we change rmw_take() and rmw_take_with_info() to do the error checking and call __rmw_take_one(). Finally we implement rmw_take_sequence() by calling __rwm_take_one() in a loop. Signed-off-by: Chris Lalancette <[email protected]>
Yadunund
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this isn't currently used by rclcpp and rclpy, it is used inside of rcl, specifically in testing. Thus we need to implement it to pass all rcl tests.
To reduce code duplication, this commit refactors __rmw_take() to handle this case. In particular, we rename __rmw_take() to __rmw_take_one(), with no error checking. Then we change rmw_take() and rmw_take_with_info() to do the error checking and call __rmw_take_one(). Finally we implement rmw_take_sequence() by calling __rwm_take_one() in a loop.