Combine the check and attach loops. #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a performance optimization. We notice that we *always* attempt to detach the condition, regardless of whether we've attached it to begin with. We can use that to our advantage, in that during the initial iteration to check if something has triggered, we can also attach at the same time. This saves us from having to iterate over the wait set again later on. There is a downside here in that we may end up attaching things that we didn't need, but we also only do that up until something is ready. So this is probably a performance win in the usual cases. Signed-off-by: Chris Lalancette <[email protected]>
Yadunund
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a performance optimization. We notice that we always attempt to detach the condition, regardless of whether we've attached it to begin with. We can use that to our advantage, in that during the initial iteration to check if something has triggered, we can also attach at the same time. This saves us from having to iterate over the wait set again later on. There is a downside here in that we may end up attaching things that we didn't need, but we also only do that up until something is ready. So this is probably a performance win in the usual cases.