Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document procedure to kill stale ros2 daemons #185

Merged
merged 5 commits into from
May 29, 2024

Conversation

berndpfrommer
Copy link
Contributor

This is related to issue #184

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpicks

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Timple
Copy link
Contributor

Timple commented May 29, 2024

Maybe not the correct place to ask. But might ROS be improved such that the daemon is only spawned for rmw's that need it?

berndpfrommer and others added 4 commits May 29, 2024 07:52
Co-authored-by: Yadu <[email protected]>
Signed-off-by: Bernd Pfrommer <[email protected]>
Co-authored-by: Yadu <[email protected]>
Signed-off-by: Bernd Pfrommer <[email protected]>
Co-authored-by: Yadu <[email protected]>
Signed-off-by: Bernd Pfrommer <[email protected]>
Co-authored-by: Yadu <[email protected]>
Signed-off-by: Bernd Pfrommer <[email protected]>
@berndpfrommer
Copy link
Contributor Author

Accepted your suggested changes, LGTM.

@Yadunund
Copy link
Member

Maybe not the correct place to ask. But might ROS be improved such that the daemon is only spawned for rmw's that need it?

It may be worth having a discussion on https://github.com/ros2/ros2cli/tree/rolling. But imo even rmw_zenoh benefits from the daemon (which will be started automatically when there isn't one running and your run a ros2 topic/node command) since these graph queries can be made without initializing a new ROS context and hence waiting to connect with the Zenoh router; instead, we can query this information from the daemon node that has already connected to the router. Perhaps ros2 shutdown command will be helpful to ensure all ROS 2 nodes and daemons are terminated before users switch to another RMW.

@Yadunund Yadunund merged commit 60b131e into ros2:rolling May 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants