-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document procedure to kill stale ros2 daemons #185
document procedure to kill stale ros2 daemons #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpicks
Maybe not the correct place to ask. But might ROS be improved such that the daemon is only spawned for rmw's that need it? |
Co-authored-by: Yadu <[email protected]> Signed-off-by: Bernd Pfrommer <[email protected]>
Co-authored-by: Yadu <[email protected]> Signed-off-by: Bernd Pfrommer <[email protected]>
Co-authored-by: Yadu <[email protected]> Signed-off-by: Bernd Pfrommer <[email protected]>
Co-authored-by: Yadu <[email protected]> Signed-off-by: Bernd Pfrommer <[email protected]>
Accepted your suggested changes, LGTM. |
It may be worth having a discussion on https://github.com/ros2/ros2cli/tree/rolling. But imo even |
This is related to issue #184