Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS and compression features by default #180

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

JEnoch
Copy link
Contributor

@JEnoch JEnoch commented May 24, 2024

Both TLS and compression are important features available in Zenoh.
This PR make them build by default for rmw_zenoh.

It also updates a comment wrt. threading and Tokio. This comment became obsolete after the switch of Zenoh from async_std to Tokio.

@JEnoch
Copy link
Contributor Author

JEnoch commented May 24, 2024

@Yadunund do you think the comment I changed in this PR is good enough for #179 ?

BTW, the compression we enabled in config during our test today was actually not active, because the feature wasn't built... 😅

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these features. Just pushed some minor tweaks.

BTW, the compression we enabled in config during our test today was actually not active, because the feature wasn't built... 😅

Whoops!

@Yadunund Yadunund merged commit d91a498 into ros2:rolling May 24, 2024
6 checks passed
@JEnoch JEnoch deleted the enable_tls branch December 23, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants