Remove all 'z_encoding(Z_ENCODING_PREFIX_EMPTY, NULL)' as default is EMPTY encoding #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hwoithe can you confirm if these changes fixes the issue you encounter? |
|
This does fix the issue for me. Thank you! |
Yadunund
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default in all options
zenoh-cset theencodingto the EMPTY encoding.Thus the calls setting encoding to
z_encoding(Z_ENCODING_PREFIX_EMPTY, NULL);are useless and can be removed.Moreover this fixes #177 which is caused by an issue passing
NULLtoz_encoding()(eclipse-zenoh/zenoh-c#370).