git is required in buildstep

[Timple]

It's probably not coming in via ament_cmake_vendor_package as that package supports multiple vcs.

[christophebedard]

I did a search for >git</ in my ROS 2 source workspace and I only see <buildtool_depend>, not <build_depend>:

$ ag '>git</' src/
src/eclipse-iceoryx/iceoryx/iceoryx_posh/package.xml
14:    <buildtool_depend>git</buildtool_depend>

src/ros2/rosbag2/mcap_vendor/package.xml
13:  <buildtool_depend>git</buildtool_depend>

src/ament/google_benchmark_vendor/package.xml
19:  <buildtool_depend>git</buildtool_depend>

src/eProsima/foonathan_memory_vendor/package.xml
14:  <buildtool_depend>git</buildtool_depend>

So should it be <buildtool_depend> or <build_depend>?

[Yadunund]

@christophebedard you're right buildtool_depend is the more appropriate one. We should also update the cargo dep to be buildtool_depend. Do you mind opening a PR?

[Timple]

My rationale was: It's used by cargo which is build_depend.

Although I'm not that sure anymore it was cargo which used it.

[Yadunund]

Actually git should be used by ament_vendor here to clone in zenoh-c. But I think this is transitively satisfied by the python3-vcstool dep defined here.

[clalancette]

Actually git should be used by ament_vendor here to clone in zenoh-c. But I think this is transitively satisfied by the python3-vcstool dep defined here.

The thing is, @Timple is right; python3-vcstool has no git dependency:

ubuntu-24.04:~$ sudo apt-cache depends python3-vcstool
python3-vcstool
  Depends: python3-pkg-resources
  Depends: python3-yaml
  Depends: <python3:any>
    python3
  Depends: python3-setuptools
  Conflicts: <python-vcstool>

[Yadunund]

Ah thanks for the clarification @clalancette.