Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indefinite timeout for queries #133

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Indefinite timeout for queries #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions rmw_zenoh_cpp/src/rmw_zenoh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,6 +2234,11 @@ rmw_send_request(
opts.attachment = z_bytes_map_as_attachment(&map);

opts.target = Z_QUERY_TARGET_ALL_COMPLETE;
// The default timeout for a z_get query is 10 seconds and if a response is not received within
// this window, the queryable will return an invalid reply. However, it is common for actions,
// which are implemented using services, to take an extended duration to complete.Hence, we set
// the timeout_ms to the largest supported value to account for most realistic scenarios.
opts.timeout_ms = std::numeric_limits<uint64_t>::max();
// Latest consolidation guarantees unicity of replies for the same key expression,
// which optimizes bandwidth. The default is "None", which imples replies may come in any order
// and any number.
Expand Down
Loading