Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was creating the design document, I noticed a few things around the code that could be cleaned up and made faster. This PR:
make_scope_exit
.z_bytes_map_insert_by_copy
will do a copy anyway, just pass in the array.rmw_destroy_service
, callz_undeclare_queryable
to drop the queryable. I believe that this is functionally equivalent toz_drop
, but I also think it is more self-documenting to usez_undeclare_queryable
here.