Apply suggestions from code review

Co-authored-by: Yadu <[email protected]> Signed-off-by: Chris Lalancette <[email protected]>
ros2 · Jun 24, 2024 · 139e082 · 139e082
1 parent 08cb5e8
commit 139e082
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/rmw_zenoh_cpp/src/detail/event.cpp b/rmw_zenoh_cpp/src/detail/event.cpp
@@ -198,7 +198,7 @@ bool EventsManager::detach_condition_and_event_queue_is_empty(rmw_zenoh_event_ty
       "RMW Zenoh is not correctly configured to handle rmw_zenoh_event_type_t [%d]. "
       "Report this bug.",
       event_id);
-    return false;
+    return true;
   }
 
   std::lock_guard<std::mutex> lock(event_condition_mutex_);

diff --git a/rmw_zenoh_cpp/src/rmw_zenoh.cpp b/rmw_zenoh_cpp/src/rmw_zenoh.cpp
@@ -3310,7 +3310,6 @@ rmw_wait(
 
   // According to the documentation for rmw_wait in rmw.h, entries in the various arrays that have
   // *not* been triggered should be set to NULL
-
   if (guard_conditions) {
     for (size_t i = 0; i < guard_conditions->guard_condition_count; ++i) {
       rmw_zenoh_cpp::GuardCondition * gc =