Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for spin_until_timeout (#1821)" #1956

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jun 24, 2022

Reverts #1874

See the reason here: #1874 (comment)

…uture_complete with spin_until_complete. (#1821) (#1874)"

This reverts commit 3c8e89d.
@wjwwood wjwwood requested a review from clalancette June 24, 2022 18:06
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me once the Rpr job comes back green.

I'm happy with just the Rpr job because nothing else was merged since #1951 a couple of days ago, so we have pretty good confidence in that.

The only other thing I'll request when merging this is that we open a "Revert Revert" PR so we can get that ready to go once the dependent PRs are ready.

@wjwwood wjwwood merged commit f43a919 into master Jun 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the revert-1874-hliberacki/timeout branch June 24, 2022 18:21
wjwwood added a commit that referenced this pull request Jun 24, 2022
…_until_future_complete with spin_until_complete. (#1821) (#1874)" (#1956)"

This reverts commit f43a919.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants