Apply build patches for ROS release. #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Install package.xml file. * Disable building unit tests. * Disable installation of bash completion. This breaks in catkin install_isolated.
cottsay
force-pushed
the
release/rolling/ifm3d_core
branch
from
40a9bbc
to
60aedc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating Rolling to new platforms in ros/rosdistro#32036 a problem with the migration script (ros/rosdistro#32128) caused patches on release/, rpm/, and debian/ branches to be wiped out.
I took a backup before the migration and am in the process of re-applying lost patches and this is one of them.
@theseankelly this is a rollup of the patches applied on the
release/rolling/ifm3d_corebranch. Bloom is more robust to individual patches which is why I committed these together rather than cherry-picking the original commits.With your approval I'll merge this PR and then bloom a debinc / release revision of ifm3d in order to restore this patch behavior. If this patch shouldn't be restored for some reason then this PR can just be closed.