Fix Dotnet & Mono build warnings #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOTNET_CORE to DotNetCore MONO to Mono
|
This MR should fix ros2-dotnet/ros2_dotnet#75 |
5 tasks
hoffmann-stefan
added a commit
to hoffmann-stefan/ros2_dotnet
that referenced
this pull request
Jul 29, 2024
hoffmann-stefan
added a commit
to hoffmann-stefan/ros2_dotnet
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed naming:
DOTNET_CORE to DotNetCore
MONO to Mono
Fixes the following warning in the windows build:
CMake Warning (dev) at C:/opt/ros/foxy/x64/Lib/site-packages/cmake/data/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message):
The package name passed to find_package_handle_standard_args
(DOTNET_CORE) does not match the name of the calling package (DotNetCore).
This can lead to problems in calling code that expects find_package
result variables (e.g., _FOUND) to follow a certain pattern.
Same was for the Mono part.
Only changed the naming, tested it with Windows 11 + Humble & Ubuntu 22.04 + Humble