Updates to the review guidelines. #36034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove the section about changing maintainers. That actually doesn't happen in this repository, but instead happens over at https://github.com/ros2-gbp/ros2-gbp-github-org/ . 2. Add a note about package names having to conform to REP-144. 3. Add a note about rosdep keys preferring to use native packages, and preferring to use the Ubuntu package name as the key name. Signed-off-by: Chris Lalancette <[email protected]>
emersonknapp
approved these changes
Feb 2, 2023
audrow
approved these changes
Feb 6, 2023
|
I'm going to go ahead and merge this one; @tfoote if you have particular comments, feel free to open another PR and we can discuss there. |
|
I tracked the lost info here: #36047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette [email protected]
@tfoote This undoes the changes from #28000, but I think it makes sense to remove this from here now.
@emersonknapp @SteveMacenski FYI