Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] flag for jpeg compression of bayer format #98

Open
wants to merge 3 commits into
base: rolling
Choose a base branch
from

Conversation

wodtko
Copy link

@wodtko wodtko commented May 13, 2022

This PR adds a flag that allows for jpeg compression of Bayer encoded images.
Although I fully understand why one does not want a lossy compression of Bayer encoded image, it worked pretty well for us when testing it with multiple camera images.

We really want to use compressed Bayer images to get recordings smaller, e.g. we record 10Hz image_streams of 8 cameras with 3MP each.
With this PR there is no need for "inflating" the data to a color image prior to compression.

@wodtko
Copy link
Author

wodtko commented Feb 28, 2023

is there any reason for not introducing this this parameter?
We are using this functionality every time, but we need to keep it forked...

@wodtko
Copy link
Author

wodtko commented Feb 28, 2023

conflicts are fairly simple and I will solve them, if the general idea is welcomed.

@andrei-ng
Copy link

andrei-ng commented Aug 18, 2023

I would also be interested in this, any maintainer willing to review this? @wodtko , you may be interested in my comment on #68

@andrei-ng andrei-ng mentioned this pull request Aug 18, 2023
@wodtko
Copy link
Author

wodtko commented Aug 31, 2023

Thanks for bringing it up again @andrei-ng :D
I was only using ROS2 in this specific context, so I'm not sure about the exact issue in ros noetic.

However, different to the result in the issue mentioned, the bayer image is currently converted to a mono image prior to compression.
Thus, there is no way of retrieving a color image afterwards...
This PR adds a separate section for handling bayer formats to omit the mono color conversion.

@andrei-ng
Copy link

Thanks for bringing it up again @andrei-ng :D I was only using ROS2 in this specific context, so I'm not sure about the exact issue in ros noetic.

However, different to the result in the issue mentioned, the bayer image is currently converted to a mono image prior to compression. Thus, there is no way of retrieving a color image afterwards... This PR adds a separate section for handling bayer formats to omit the mono color conversion.

@wodtko , thanks for the clarification. I haven't used ROS2 in this context. I hope that by the time I use it, your PR will be merged :) .

@wodtko
Copy link
Author

wodtko commented Sep 4, 2023

Well, if anyone would review my changes, I would be happy to resolve any CI issues.
(mainly rebasing this PR)

@wodtko wodtko force-pushed the feat_allow_bayer_jpeg_compression branch from 4c2a8a5 to 8be68ec Compare April 4, 2024 08:59
@wodtko wodtko force-pushed the feat_allow_bayer_jpeg_compression branch from 8be68ec to b14c904 Compare July 28, 2024 09:03
@wodtko wodtko force-pushed the feat_allow_bayer_jpeg_compression branch from b14c904 to d297944 Compare July 28, 2024 09:05
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to fix the conflicts?

@wodtko wodtko force-pushed the feat_allow_bayer_jpeg_compression branch 2 times, most recently from a3700d2 to b7873c1 Compare August 6, 2024 07:19
@wodtko wodtko force-pushed the feat_allow_bayer_jpeg_compression branch from b7873c1 to 01e38b7 Compare August 6, 2024 07:20
@wodtko
Copy link
Author

wodtko commented Aug 6, 2024

All conflicts are fixed, and the number of lines changed was reduced.

I would highly appreciate any review/merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants