Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone the upstream repositories of navigation2 repo #7

Conversation

CihatAltiparmak
Copy link
Contributor

@CihatAltiparmak CihatAltiparmak commented Jan 4, 2025

Hello, The problem here is that the dockerfile uses upstream packages like nav2_minimal_turtlebot_simulation from apt instead of using it from latest version of source code.

Instances for fails:

I've tried the latest docker image of nav2 rolling and even basic demo doesn't work as expected. I send a goal pose. Planner plans, controller acts and publish to cmd_vel topic. However robot doesn't move in simulation owing to the fact that nav2_minimal_turtlebot_simulation is not in latest version in these docker image produced in this CI. So the fixes in accordance with ros-navigation/navigation2#4779 are not applied in these images as long as nav2_minimal_turtlebot_simulation package is not updated in apt.

Note that I couldn't test it in rolling, but tested in jazzy and seems works as expected.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't make sense for released distributions, but I agree for Rolling. When there's some temporary issue that we're building against other versions for, that's when we use that underlay space. Please update for only Rolling ("${ROS_DISTRO}" = "rolling" condition).

I just made a note in my calendar for Monday to do a release for TB3/4 to fix the Rolling issues w.r.t. TwistStamped migration, so that should be fixed in the next Rolling sync in about a month.

Please also fix DCO and I should be able to merge this.

@CihatAltiparmak CihatAltiparmak force-pushed the fix/build_upstream_repos_from_source branch from 76f57b3 to 348797c Compare January 5, 2025 13:41
@SteveMacenski SteveMacenski merged commit 6f1d318 into ros-navigation:main Jan 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants