Clone the upstream repositories of navigation2 repo #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, The problem here is that the dockerfile uses upstream packages like nav2_minimal_turtlebot_simulation from apt instead of using it from latest version of source code.
Instances for fails:
I've tried the latest docker image of nav2 rolling and even basic demo doesn't work as expected. I send a goal pose. Planner plans, controller acts and publish to
cmd_vel
topic. However robot doesn't move in simulation owing to the fact that nav2_minimal_turtlebot_simulation is not in latest version in these docker image produced in this CI. So the fixes in accordance with ros-navigation/navigation2#4779 are not applied in these images as long as nav2_minimal_turtlebot_simulation package is not updated in apt.Note that I couldn't test it in rolling, but tested in jazzy and seems works as expected.