Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detection logic for Fedora Asahi Remix #265

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add detection logic for Fedora Asahi Remix #265

merged 1 commit into from
Mar 1, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Feb 10, 2024 •
edited
Loading

Requires #264

@cottsay cottsay self-assigned this Feb 10, 2024
@cottsay cottsay linked an issue Feb 10, 2024 that may be closed by this pull request
Supporting Fedora Asahi Remix ros-infrastructure/rosdep#939
Closed
Base automatically changed from cottsay/update-ci-matrix to master February 12, 2024 15:21
@cottsay cottsay marked this pull request as ready for review February 12, 2024 15:21
@tfoote
Copy link
Member

tfoote commented Mar 1, 2024

Is there a docker image that this can be tested or validated against?

tfoote
tfoote approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks fine. Without an image to test against I can't validate this will work. But it shouldn't break anything.

@cottsay
Copy link
Member Author

cottsay commented Mar 1, 2024

I don't have actual hardware with which to test this, but I derived the ID from the os-release source in the RPM spec file: https://copr-dist-git.fedorainfracloud.org/cgit/@asahi/fedora-remix-branding/fedora-asahi-remix-release.git/tree/fedora-asahi-remix-release.spec#n1377

@cottsay cottsay merged commit ed5f484 into master Mar 1, 2024
13 checks passed
@cottsay cottsay deleted the cottsay/fedora-asahi branch March 1, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees

@cottsay cottsay

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting Fedora Asahi Remix
2 participants
@cottsay @tfoote