Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect and report all resolution errors. #788

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Collect and report all resolution errors. #788

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47495bf
WIPWIP
nuclearsandwich Nov 14, 2020
01bc6d4
Merge remote-tracking branch 'origin/master' into nuclearsandwich/mul…
nuclearsandwich Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/rosdep2/lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,9 +422,15 @@ def resolve_all(self, resources, installer_context, implicit=False):
depend_graph[depend_rosdep_key]['dependencies'] = list(more_dependencies)

except ResolutionError as e:
errors[resource_name] = e
if resource_name in errors:
errors[resource_name].append(e)
else:
errors[resource_name] = [e]
except ResourceNotFound as e:
errors[resource_name] = e
if resource_name in errors:
errors[resource_name].append(e)
else:
errors[resource_name] = [e]

try:
# TODO: I really don't like AssertionErrors here; this should be modeled as 'CyclicGraphError'
Expand Down