Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework some sharp edges in GitHub Actions #198

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Rework some sharp edges in GitHub Actions #198

merged 3 commits into from
Feb 13, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Feb 13, 2024 •
edited
Loading

Two high-level changes here:

  • Drop the matrix in favor of conditionally running steps
    The job runs so fast that I don't think there's any advantage in parallelizing using the matrix
  • Use base ref SHA for determining which files changed
    The intent here is to make PRs from forks work by not referencing origin.

@cottsay cottsay self-assigned this Feb 13, 2024
@cottsay cottsay marked this pull request as ready for review February 13, 2024 16:25
nuclearsandwich
nuclearsandwich approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a lot cleaner to read!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@j-rivero
Copy link
Contributor

Worked after I tried it on my fork here j-rivero#5

j-rivero
j-rivero reviewed Feb 13, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
j-rivero
j-rivero approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion to rename the CI steps. Looks good.

@cottsay @j-rivero
Update .github/workflows/ci.yml
a4a4dd3 
Co-authored-by: Jose Luis Rivero <[email protected]>
@cottsay cottsay merged commit 8ba1c57 into master Feb 13, 2024
1 check passed
@cottsay cottsay deleted the cottsay/gh-action branch February 13, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@j-rivero j-rivero j-rivero approved these changes

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cottsay @j-rivero @nuclearsandwich