Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for deploying to the ROS bootstrap repo. #135

Merged
merged 6 commits into from
Oct 9, 2024
Merged

Add docs for deploying to the ROS bootstrap repo. #135

merged 6 commits into from
Oct 9, 2024

Conversation

nuclearsandwich
Copy link
Contributor

First draft of ros_bootstrap repo deployment docs.

@nuclearsandwich nuclearsandwich self-assigned this Nov 29, 2021
j-rivero
j-rivero reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial instructions seems great to me, thanks!

I miss a bit of "what could go wrong" or how risky is the step doing when running aptly_importer.py, the ~/bin/snapshot-and-publish-all or the import job on Jenkins and how to behave if problems appear.

doc/deploying_ros_bootstrap_repo_imports.md Outdated Show resolved Hide resolved
doc/deploying_ros_bootstrap_repo_imports.md Outdated Show resolved Hide resolved
j-rivero
j-rivero reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the numbering seems to be broken when github renders the Updating section.

j-rivero
j-rivero approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good to go !

@nuclearsandwich nuclearsandwich merged commit f1bf491 into master Oct 9, 2024
1 check passed
@nuclearsandwich nuclearsandwich deleted the doc branch October 9, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-rivero j-rivero j-rivero approved these changes

@cottsay cottsay Awaiting requested review from cottsay

Assignees

@nuclearsandwich nuclearsandwich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuclearsandwich @j-rivero