-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kuka KR 16 R1610 cybertech support #146
base: melodic-devel
Are you sure you want to change the base?
Add Kuka KR 16 R1610 cybertech support #146
Conversation
Just a small update: this package has been used and tested extensible now. The ikfast plugin was created on kinetic and seems to create problems here on indigo (C++98vsC++11?) |
@gavanderhoorn @BrettHemes I would be really grateful for some feedback on naming. We have a current request from a client for the new Kuka Ionic KR70 R2100 and same as here I'm wondering if it should be |
Not really sure here, but we haven't used the informal series names anywhere else in the package names (e.g. Agilus). They are, I believe, mentioned in the manifests. I think it comes down to preference. I would vote for consistency, however. |
it has nothing in common with the traditional KR16-2, therefore it resides in its own package
b7fc591
to
75c5ad3
Compare
This now follows the naming standards of having the variant last. I think the |
And |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High-level comment (which I've also placed in-line): I'd like us to consider adding an underscore before the family modifier, so we'd get kuka_kr16r1610_cybertech
.
I've left some other in-line comments.
kuka_kr16_support/CMakeLists.txt
Outdated
@@ -9,6 +9,7 @@ catkin_package() | |||
if (CATKIN_ENABLE_TESTING) | |||
find_package(roslaunch REQUIRED) | |||
roslaunch_add_file_check(test/roslaunch_test.xml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also rename this test?
This adds support for the Kuka cybertech KR16 R1610 model. It does not have that much in common with the Kuka KR16-2 already supported. Therefore I added completely separate packages.
In the technical specification [1] it is referred to as "kr16 r1610" ie omitting the "cybertech" part. I added it to the package name anyway as it helps in distinguishing the product lines. We will test this one on real hardware starting next week so it should not be merged yet. I would however be grateful about naming advice and therefore open the PR already.
https://www.kuka.com/-/media/kuka-downloads/imported/48ec812b1b2947898ac2598aff70abc0/spez_kr_cybertech_en.pdf